Good morning. As Eric mentioned in last week's Arch call, the Kata team at Intel are trialing a 'round robin Gatekeeper schedule' for Kata PR review. That is, each week one of our team will prioritise reviewing and moving forwards the open PRs on the Kata repos. This is a process we used for some time with Clear Containers.
We are trying this out to see if we can try and reduce the pending PR list, in particular some of the longer standing or more urgent PRs.
This is by no means an Intel-only initiative :-) If you want to be on the rota then just let me know and I'll add you into the cycle. It would be great if we can try and get at least two nominated reviewers each week, ideally located in different time zones.
Note that to be a gatekeeper you don't have to understand the whole project, or even have to be the most technical person. Being a gatekeeper is a great opportunity to both get to know the project in more depth and to hone your technical skills. Sometimes all it needs is for somebody to read the list of open PRs and nudge a few along that have been inactive and ask the appropriate domain experts if they could do a review. All volunteers welcome.
If you are new to the project and/or PR reviews, we have a PR review guide document that is well worth reviewing: https://github.com/kata-containers/community/blob/master/PR-Review-Guide.md .
Today we are sat with 42 open items (you can coax that info out of github via this link: https://github.com/search?o=asc&q=org%3Akata-containers+is%3Apr+is%3Aope...).
This week's gatekeeper is .... myself :-)
Graham
--------------------------------------------------------------------- Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
This is a great idea. Thanks for doing this. :)
I would recommend coming up with a different term then 'gatekeeper' though to describe it. It could have an undesired connotation in the world of opensource. Just a thought.
Thanks, Kevin ________________________________________ From: Whaley, Graham [graham.whaley@intel.com] Sent: Monday, August 06, 2018 1:27 AM To: kata-dev@lists.katacontainers.io Subject: [kata-dev] Intel Gatekeepers for Kata
Good morning. As Eric mentioned in last week's Arch call, the Kata team at Intel are trialing a 'round robin Gatekeeper schedule' for Kata PR review. That is, each week one of our team will prioritise reviewing and moving forwards the open PRs on the Kata repos. This is a process we used for some time with Clear Containers.
We are trying this out to see if we can try and reduce the pending PR list, in particular some of the longer standing or more urgent PRs.
This is by no means an Intel-only initiative :-) If you want to be on the rota then just let me know and I'll add you into the cycle. It would be great if we can try and get at least two nominated reviewers each week, ideally located in different time zones.
Note that to be a gatekeeper you don't have to understand the whole project, or even have to be the most technical person. Being a gatekeeper is a great opportunity to both get to know the project in more depth and to hone your technical skills. Sometimes all it needs is for somebody to read the list of open PRs and nudge a few along that have been inactive and ask the appropriate domain experts if they could do a review. All volunteers welcome.
If you are new to the project and/or PR reviews, we have a PR review guide document that is well worth reviewing: https://github.com/kata-containers/community/blob/master/PR-Review-Guide.md .
Today we are sat with 42 open items (you can coax that info out of github via this link: https://github.com/search?o=asc&q=org%3Akata-containers+is%3Apr+is%3Aope...).
This week's gatekeeper is .... myself :-)
Graham
--------------------------------------------------------------------- Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
_______________________________________________ kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
Ah, that is true - we are indeed not here to block anything - in fact, hopefully the opposite! I'm open to suggestions. @anne, any ideas or precedents? Maybe just 'review team' will do?
(the fun link between having the Gatekeeper team and us trialling Zuul for our CI had not escaped me btw ;-) )
Oh, and I can't take all the credit here - a few of us started this on ClearContainers some time back, and EricE asked to resurrect it for Kata :-)
Graham
-----Original Message----- From: Fox, Kevin M [mailto:Kevin.Fox@pnnl.gov] Sent: Monday, August 6, 2018 5:41 PM To: Whaley, Graham graham.whaley@intel.com; kata- dev@lists.katacontainers.io Subject: RE: Intel Gatekeepers for Kata
This is a great idea. Thanks for doing this. :)
I would recommend coming up with a different term then 'gatekeeper' though to describe it. It could have an undesired connotation in the world of opensource. Just a thought.
Thanks, Kevin ________________________________________ From: Whaley, Graham [graham.whaley@intel.com] Sent: Monday, August 06, 2018 1:27 AM To: kata-dev@lists.katacontainers.io Subject: [kata-dev] Intel Gatekeepers for Kata
Good morning. As Eric mentioned in last week's Arch call, the Kata team at Intel are trialing a 'round robin Gatekeeper schedule' for Kata PR review. That is, each week one of our team will prioritise reviewing and moving forwards the open PRs on the Kata repos. This is a process we used for some time with Clear Containers.
We are trying this out to see if we can try and reduce the pending PR list, in particular some of the longer standing or more urgent PRs.
This is by no means an Intel-only initiative :-) If you want to be on the rota then just let me know and I'll add you into the cycle. It would be great if we can try and get at least two nominated reviewers each week, ideally located in different time zones.
Note that to be a gatekeeper you don't have to understand the whole project, or even have to be the most technical person. Being a gatekeeper is a great opportunity to both get to know the project in more depth and to hone your technical skills. Sometimes all it needs is for somebody to read the list of open PRs and nudge a few along that have been inactive and ask the appropriate domain experts if they could do a review. All volunteers welcome.
If you are new to the project and/or PR reviews, we have a PR review guide document that is well worth reviewing: https://github.com/kata- containers/community/blob/master/PR-Review-Guide.md .
Today we are sat with 42 open items (you can coax that info out of github via this link: https://github.com/search?o=asc&q=org%3Akata- containers+is%3Apr+is%3Aopen&s=created&type=Issues).
This week's gatekeeper is .... myself :-)
Graham
Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
--------------------------------------------------------------------- Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
I also think this is a great idea. I’d encourage folks to think of the process as transcending organization affiliation; we’re all members of the Kata Community now, so anyone is welcome to jump in!
I think “review team” is a fine term, could even try to make a fun acronym out of “Reviewer of the Week” or something of the like (ROTW…ROW…ROW Master…still workshopping!).
If a week is too long to be Rowing, we could explore people volunteering for one day a week? (You take every Monday…Graham takes Tuesdays…etc). There’d be some overlap because of time zone, but maybe a little lower commitment than being on for the full week.
Anne Bertucio OpenStack Foundation anne@openstack.org | irc: annabelleB
On Aug 6, 2018, at 9:49 AM, Whaley, Graham graham.whaley@intel.com wrote:
Ah, that is true - we are indeed not here to block anything - in fact, hopefully the opposite! I'm open to suggestions. @anne, any ideas or precedents? Maybe just 'review team' will do?
(the fun link between having the Gatekeeper team and us trialling Zuul for our CI had not escaped me btw ;-) )
Oh, and I can't take all the credit here - a few of us started this on ClearContainers some time back, and EricE asked to resurrect it for Kata :-)
Graham
-----Original Message----- From: Fox, Kevin M [mailto:Kevin.Fox@pnnl.gov mailto:Kevin.Fox@pnnl.gov] Sent: Monday, August 6, 2018 5:41 PM To: Whaley, Graham <graham.whaley@intel.com mailto:graham.whaley@intel.com>; kata- dev@lists.katacontainers.io mailto:dev@lists.katacontainers.io Subject: RE: Intel Gatekeepers for Kata
This is a great idea. Thanks for doing this. :)
I would recommend coming up with a different term then 'gatekeeper' though to describe it. It could have an undesired connotation in the world of opensource. Just a thought.
Thanks, Kevin ________________________________________ From: Whaley, Graham [graham.whaley@intel.com] Sent: Monday, August 06, 2018 1:27 AM To: kata-dev@lists.katacontainers.io Subject: [kata-dev] Intel Gatekeepers for Kata
Good morning. As Eric mentioned in last week's Arch call, the Kata team at Intel are trialing a 'round robin Gatekeeper schedule' for Kata PR review. That is, each week one of our team will prioritise reviewing and moving forwards the open PRs on the Kata repos. This is a process we used for some time with Clear Containers.
We are trying this out to see if we can try and reduce the pending PR list, in particular some of the longer standing or more urgent PRs.
This is by no means an Intel-only initiative :-) If you want to be on the rota then just let me know and I'll add you into the cycle. It would be great if we can try and get at least two nominated reviewers each week, ideally located in different time zones.
Note that to be a gatekeeper you don't have to understand the whole project, or even have to be the most technical person. Being a gatekeeper is a great opportunity to both get to know the project in more depth and to hone your technical skills. Sometimes all it needs is for somebody to read the list of open PRs and nudge a few along that have been inactive and ask the appropriate domain experts if they could do a review. All volunteers welcome.
If you are new to the project and/or PR reviews, we have a PR review guide document that is well worth reviewing: https://github.com/kata- containers/community/blob/master/PR-Review-Guide.md .
Today we are sat with 42 open items (you can coax that info out of github via this link: https://github.com/search?o=asc&q=org%3Akata- containers+is%3Apr+is%3Aopen&s=created&type=Issues).
This week's gatekeeper is .... myself :-)
Graham
Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
kata-dev mailing list kata-dev@lists.katacontainers.io mailto:kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
Hi Graham,
I agree that this is a great idea. :) As for team names, how about something cooperative-sounding like "PR Shepherd"?
Sincerely, Jesse
-----Original Message----- From: Whaley, Graham graham.whaley@intel.com Sent: Monday, August 6, 2018 11:49 AM To: Fox, Kevin M Kevin.Fox@pnnl.gov; kata-dev@lists.katacontainers.io Subject: Re: [kata-dev] Intel Gatekeepers for Kata
Ah, that is true - we are indeed not here to block anything - in fact, hopefully the opposite! I'm open to suggestions. @anne, any ideas or precedents? Maybe just 'review team' will do?
(the fun link between having the Gatekeeper team and us trialling Zuul for our CI had not escaped me btw ;-) )
Oh, and I can't take all the credit here - a few of us started this on ClearContainers some time back, and EricE asked to resurrect it for Kata :-)
Graham
-----Original Message----- From: Fox, Kevin M [mailto:Kevin.Fox@pnnl.gov] Sent: Monday, August 6, 2018 5:41 PM To: Whaley, Graham graham.whaley@intel.com; kata- dev@lists.katacontainers.io Subject: RE: Intel Gatekeepers for Kata
This is a great idea. Thanks for doing this. :)
I would recommend coming up with a different term then 'gatekeeper'
though
to describe it. It could have an undesired connotation in the world of opensource. Just a thought.
Thanks, Kevin ________________________________________ From: Whaley, Graham [graham.whaley@intel.com] Sent: Monday, August 06, 2018 1:27 AM To: kata-dev@lists.katacontainers.io Subject: [kata-dev] Intel Gatekeepers for Kata
Good morning. As Eric mentioned in last week's Arch call, the Kata team at Intel are trialing
a
'round robin Gatekeeper schedule' for Kata PR review. That is, each week
one of
our team will prioritise reviewing and moving forwards the open PRs on the
Kata
repos. This is a process we used for some time with Clear Containers.
We are trying this out to see if we can try and reduce the pending PR list, in particular some of the longer standing or more urgent PRs.
This is by no means an Intel-only initiative :-) If you want to be on the rota
then
just let me know and I'll add you into the cycle. It would be great if we can
try
and get at least two nominated reviewers each week, ideally located in
different
time zones.
Note that to be a gatekeeper you don't have to understand the whole
project,
or even have to be the most technical person. Being a gatekeeper is a great opportunity to both get to know the project in more depth and to hone
your
technical skills. Sometimes all it needs is for somebody to read the list of
open
PRs and nudge a few along that have been inactive and ask the appropriate domain experts if they could do a review. All volunteers welcome.
If you are new to the project and/or PR reviews, we have a PR review
guide
document that is well worth reviewing: https://github.com/kata- containers/community/blob/master/PR-Review-Guide.md .
Today we are sat with 42 open items (you can coax that info out of github
via
this link: https://github.com/search?o=asc&q=org%3Akata- containers+is%3Apr+is%3Aopen&s=created&type=Issues).
This week's gatekeeper is .... myself :-)
Graham
Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
Great idea, +1. Count me in!
Cheers.
On Mon, Aug 6, 2018 at 11:47 AM, Larrew, Jesse Jesse.Larrew@amd.com wrote:
Hi Graham,
I agree that this is a great idea. :) As for team names, how about something cooperative-sounding like "PR Shepherd"?
Sincerely, Jesse
-----Original Message----- From: Whaley, Graham graham.whaley@intel.com Sent: Monday, August 6, 2018 11:49 AM To: Fox, Kevin M Kevin.Fox@pnnl.gov; kata-dev@lists.katacontainers.io Subject: Re: [kata-dev] Intel Gatekeepers for Kata
Ah, that is true - we are indeed not here to block anything - in fact,
hopefully
the opposite! I'm open to suggestions. @anne, any ideas or precedents? Maybe just 'review team' will do?
(the fun link between having the Gatekeeper team and us trialling Zuul
for
our CI had not escaped me btw ;-) )
Oh, and I can't take all the credit here - a few of us started this on ClearContainers some time back, and EricE asked to resurrect it for Kata
:-)
Graham
-----Original Message----- From: Fox, Kevin M [mailto:Kevin.Fox@pnnl.gov] Sent: Monday, August 6, 2018 5:41 PM To: Whaley, Graham graham.whaley@intel.com; kata- dev@lists.katacontainers.io Subject: RE: Intel Gatekeepers for Kata
This is a great idea. Thanks for doing this. :)
I would recommend coming up with a different term then 'gatekeeper'
though
to describe it. It could have an undesired connotation in the world of opensource. Just a thought.
Thanks, Kevin ________________________________________ From: Whaley, Graham [graham.whaley@intel.com] Sent: Monday, August 06, 2018 1:27 AM To: kata-dev@lists.katacontainers.io Subject: [kata-dev] Intel Gatekeepers for Kata
Good morning. As Eric mentioned in last week's Arch call, the Kata team at Intel are
trialing
a
'round robin Gatekeeper schedule' for Kata PR review. That is, each
week
one of
our team will prioritise reviewing and moving forwards the open PRs on
the
Kata
repos. This is a process we used for some time with Clear Containers.
We are trying this out to see if we can try and reduce the pending PR
list, in
particular some of the longer standing or more urgent PRs.
This is by no means an Intel-only initiative :-) If you want to be on
the rota
then
just let me know and I'll add you into the cycle. It would be great if
we can
try
and get at least two nominated reviewers each week, ideally located in
different
time zones.
Note that to be a gatekeeper you don't have to understand the whole
project,
or even have to be the most technical person. Being a gatekeeper is a
great
opportunity to both get to know the project in more depth and to hone
your
technical skills. Sometimes all it needs is for somebody to read the
list of
open
PRs and nudge a few along that have been inactive and ask the
appropriate
domain experts if they could do a review. All volunteers welcome.
If you are new to the project and/or PR reviews, we have a PR review
guide
document that is well worth reviewing: https://github.com/kata- containers/community/blob/master/PR-Review-Guide.md .
Today we are sat with 42 open items (you can coax that info out of
github
via
this link: https://github.com/search?o=asc&q=org%3Akata- containers+is%3Apr+is%3Aopen&s=created&type=Issues).
This week's gatekeeper is .... myself :-)
Graham
Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
On Mon, Aug 6, 2018 at 4:27 PM, Whaley, Graham graham.whaley@intel.com wrote:
Good morning. As Eric mentioned in last week's Arch call, the Kata team at Intel are trialing a 'round robin Gatekeeper schedule' for Kata PR review. That is, each week one of our team will prioritise reviewing and moving forwards the open PRs on the Kata repos. This is a process we used for some time with Clear Containers.
We are trying this out to see if we can try and reduce the pending PR list, in particular some of the longer standing or more urgent PRs.
This is by no means an Intel-only initiative :-) If you want to be on the rota then just let me know and I'll add you into the cycle. It would be great if we can try and get at least two nominated reviewers each week, ideally located in different time zones.
Note that to be a gatekeeper you don't have to understand the whole project, or even have to be the most technical person. Being a gatekeeper is a great opportunity to both get to know the project in more depth and to hone your technical skills. Sometimes all it needs is for somebody to read the list of open PRs and nudge a few along that have been inactive and ask the appropriate domain experts if they could do a review. All volunteers welcome.
If you are new to the project and/or PR reviews, we have a PR review guide document that is well worth reviewing: https://github.com/kata-containers/community/blob/master/PR-Review-Guide.md .
Today we are sat with 42 open items (you can coax that info out of github via this link: https://github.com/search?o=asc&q=org%3Akata-containers+is%3Apr+is%3Aope...).
This week's gatekeeper is .... myself :-)
This is really a good idea. Thanks for bringing it up! Count me in! We really could use some dedicated forces to push forward long running issues/PRs.
And let's not abuse gatekeeper(TM) for it. "review team" and "PR Shepherd" both sound good to me.
Cheers, Tao
Tao, Rico - thank you! for opting in
I have taken our current internal list of 'volunteers', modified it a bit and added the new volunteers in, and then embellished it with some useful other info. I've placed it up on the wiki. It can probably do with some shuffling of the rota - but we can work on that.
https://github.com/kata-containers/community/wiki/Review-Team-Rota
Can I ask all members in the Rota table to check they are available on those dates please.
JamesH and I threw around some funny names between us. Taking a bit of inspiration from JamesH and something EricE posted, I particularly like the idea of the 'Kat herding team', but I settled on the more sedate 'Kata review team'. Still, if enough folks want to change that name .... ;-)
We should probably make a top level wiki page with a link to that page (otherwise finding wiki pages on github can be a bit of an art), and probably make a PR to add a link into the community docs as well... once the page is settled then I'll try to remember to do that (and will go open an Issue for it right now..)
Graham
-----Original Message----- From: Tao Peng [mailto:bergwolf@hyper.sh] Sent: Tuesday, August 7, 2018 2:24 AM To: Whaley, Graham graham.whaley@intel.com Cc: kata-dev@lists.katacontainers.io Subject: Re: [kata-dev] Intel Gatekeepers for Kata
On Mon, Aug 6, 2018 at 4:27 PM, Whaley, Graham graham.whaley@intel.com wrote:
Good morning. As Eric mentioned in last week's Arch call, the Kata team at Intel are trialing a
'round robin Gatekeeper schedule' for Kata PR review. That is, each week one of our team will prioritise reviewing and moving forwards the open PRs on the Kata repos. This is a process we used for some time with Clear Containers.
We are trying this out to see if we can try and reduce the pending PR list, in
particular some of the longer standing or more urgent PRs.
This is by no means an Intel-only initiative :-) If you want to be on the rota then
just let me know and I'll add you into the cycle. It would be great if we can try and get at least two nominated reviewers each week, ideally located in different time zones.
Note that to be a gatekeeper you don't have to understand the whole project,
or even have to be the most technical person. Being a gatekeeper is a great opportunity to both get to know the project in more depth and to hone your technical skills. Sometimes all it needs is for somebody to read the list of open PRs and nudge a few along that have been inactive and ask the appropriate domain experts if they could do a review. All volunteers welcome.
If you are new to the project and/or PR reviews, we have a PR review guide
document that is well worth reviewing: https://github.com/kata- containers/community/blob/master/PR-Review-Guide.md .
Today we are sat with 42 open items (you can coax that info out of github via
this link: https://github.com/search?o=asc&q=org%3Akata- containers+is%3Apr+is%3Aopen&s=created&type=Issues).
This week's gatekeeper is .... myself :-)
This is really a good idea. Thanks for bringing it up! Count me in! We really could use some dedicated forces to push forward long running issues/PRs.
And let's not abuse gatekeeper(TM) for it. "review team" and "PR Shepherd" both sound good to me.
Cheers, Tao
-- bergwolf@hyper.sh
--------------------------------------------------------------------- Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
Hi,
This seems like a nice way to get familiar with the code base. I don't know if I will be able to deliver as much as the others but I would love to join you guys. Can I be assigned? Perhaps for the week starting 8/27 for APAC region?
On Wed, Aug 8, 2018 at 4:19 PM Whaley, Graham graham.whaley@intel.com wrote:
Tao, Rico - thank you! for opting in
I have taken our current internal list of 'volunteers', modified it a bit and added the new volunteers in, and then embellished it with some useful other info. I've placed it up on the wiki. It can probably do with some shuffling of the rota - but we can work on that.
https://github.com/kata-containers/community/wiki/Review-Team-Rota
Can I ask all members in the Rota table to check they are available on those dates please.
JamesH and I threw around some funny names between us. Taking a bit of inspiration from JamesH and something EricE posted, I particularly like the idea of the 'Kat herding team', but I settled on the more sedate 'Kata review team'. Still, if enough folks want to change that name .... ;-)
We should probably make a top level wiki page with a link to that page (otherwise finding wiki pages on github can be a bit of an art), and probably make a PR to add a link into the community docs as well... once the page is settled then I'll try to remember to do that (and will go open an Issue for it right now..)
Graham
-----Original Message----- From: Tao Peng [mailto:bergwolf@hyper.sh] Sent: Tuesday, August 7, 2018 2:24 AM To: Whaley, Graham graham.whaley@intel.com Cc: kata-dev@lists.katacontainers.io Subject: Re: [kata-dev] Intel Gatekeepers for Kata
On Mon, Aug 6, 2018 at 4:27 PM, Whaley, Graham graham.whaley@intel.com wrote:
Good morning. As Eric mentioned in last week's Arch call, the Kata team at Intel are
trialing a
'round robin Gatekeeper schedule' for Kata PR review. That is, each week
one of
our team will prioritise reviewing and moving forwards the open PRs on
the Kata
repos. This is a process we used for some time with Clear Containers.
We are trying this out to see if we can try and reduce the pending PR
list, in
particular some of the longer standing or more urgent PRs.
This is by no means an Intel-only initiative :-) If you want to be on
the rota then
just let me know and I'll add you into the cycle. It would be great if
we can try
and get at least two nominated reviewers each week, ideally located in
different
time zones.
Note that to be a gatekeeper you don't have to understand the whole
project,
or even have to be the most technical person. Being a gatekeeper is a
great
opportunity to both get to know the project in more depth and to hone
your
technical skills. Sometimes all it needs is for somebody to read the
list of open
PRs and nudge a few along that have been inactive and ask the appropriate domain experts if they could do a review. All volunteers welcome.
If you are new to the project and/or PR reviews, we have a PR review
guide
document that is well worth reviewing: https://github.com/kata- containers/community/blob/master/PR-Review-Guide.md .
Today we are sat with 42 open items (you can coax that info out of
github via
this link: https://github.com/search?o=asc&q=org%3Akata- containers+is%3Apr+is%3Aopen&s=created&type=Issues).
This week's gatekeeper is .... myself :-)
This is really a good idea. Thanks for bringing it up! Count me in! We really could use some dedicated forces to push forward long running issues/PRs.
And let's not abuse gatekeeper(TM) for it. "review team" and "PR Shepherd" both sound good to me.
Cheers, Tao
-- bergwolf@hyper.sh
Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
Sure, that should be no problem. I’ve added you into the table for that 8/27 slot. I will not that you are not currently a member of the kata-containers group on github – that is probably going to restrict your rights on the repos (like it may not let you merge etc.) – but, let’s see how it goes. You can still comment and nudge people on the Issues and PRs I believe, and when we get to the point where you need to start ack’ing and merging PRs, we will sort that out.
Thanks for stepping up!
Graham
From: yash jain [mailto:ydjainopensource@gmail.com] Sent: Wednesday, August 8, 2018 12:31 PM To: Whaley, Graham graham.whaley@intel.com Cc: bergwolf@hyper.sh; kata-dev@lists.katacontainers.io; raravena80@gmail.com Subject: Re: [kata-dev] Intel Gatekeepers for Kata
Hi,
This seems like a nice way to get familiar with the code base. I don't know if I will be able to deliver as much as the others but I would love to join you guys. Can I be assigned? Perhaps for the week starting 8/27 for APAC region?
On Wed, Aug 8, 2018 at 4:19 PM Whaley, Graham <graham.whaley@intel.commailto:graham.whaley@intel.com> wrote: Tao, Rico - thank you! for opting in
I have taken our current internal list of 'volunteers', modified it a bit and added the new volunteers in, and then embellished it with some useful other info. I've placed it up on the wiki. It can probably do with some shuffling of the rota - but we can work on that.
https://github.com/kata-containers/community/wiki/Review-Team-Rota
Can I ask all members in the Rota table to check they are available on those dates please.
JamesH and I threw around some funny names between us. Taking a bit of inspiration from JamesH and something EricE posted, I particularly like the idea of the 'Kat herding team', but I settled on the more sedate 'Kata review team'. Still, if enough folks want to change that name .... ;-)
We should probably make a top level wiki page with a link to that page (otherwise finding wiki pages on github can be a bit of an art), and probably make a PR to add a link into the community docs as well... once the page is settled then I'll try to remember to do that (and will go open an Issue for it right now..)
Graham
-----Original Message----- From: Tao Peng [mailto:bergwolf@hyper.shmailto:bergwolf@hyper.sh] Sent: Tuesday, August 7, 2018 2:24 AM To: Whaley, Graham <graham.whaley@intel.commailto:graham.whaley@intel.com> Cc: kata-dev@lists.katacontainers.iomailto:kata-dev@lists.katacontainers.io Subject: Re: [kata-dev] Intel Gatekeepers for Kata
On Mon, Aug 6, 2018 at 4:27 PM, Whaley, Graham <graham.whaley@intel.commailto:graham.whaley@intel.com> wrote:
Good morning. As Eric mentioned in last week's Arch call, the Kata team at Intel are trialing a
'round robin Gatekeeper schedule' for Kata PR review. That is, each week one of our team will prioritise reviewing and moving forwards the open PRs on the Kata repos. This is a process we used for some time with Clear Containers.
We are trying this out to see if we can try and reduce the pending PR list, in
particular some of the longer standing or more urgent PRs.
This is by no means an Intel-only initiative :-) If you want to be on the rota then
just let me know and I'll add you into the cycle. It would be great if we can try and get at least two nominated reviewers each week, ideally located in different time zones.
Note that to be a gatekeeper you don't have to understand the whole project,
or even have to be the most technical person. Being a gatekeeper is a great opportunity to both get to know the project in more depth and to hone your technical skills. Sometimes all it needs is for somebody to read the list of open PRs and nudge a few along that have been inactive and ask the appropriate domain experts if they could do a review. All volunteers welcome.
If you are new to the project and/or PR reviews, we have a PR review guide
document that is well worth reviewing: https://github.com/kata- containers/community/blob/master/PR-Review-Guide.md .
Today we are sat with 42 open items (you can coax that info out of github via
this link: https://github.com/search?o=asc&q=org%3Akata- containers+is%3Apr+is%3Aopen&s=created&type=Issues).
This week's gatekeeper is .... myself :-)
This is really a good idea. Thanks for bringing it up! Count me in! We really could use some dedicated forces to push forward long running issues/PRs.
And let's not abuse gatekeeper(TM) for it. "review team" and "PR Shepherd" both sound good to me.
Cheers, Tao
-- bergwolf@hyper.shmailto:bergwolf@hyper.sh
--------------------------------------------------------------------- Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ kata-dev mailing list kata-dev@lists.katacontainers.iomailto:kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
-- Thanks
Yash D Jain Github : @ydjainopensourcehttps://github.com/ydjainopensource Twitter : @Yash_D_Jainhttps://twitter.com/Yash_D_Jain LinkedIn : in/yash-d-jainhttps://www.linkedin.com/in/yash-d-jain/
--------------------------------------------------------------------- Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
+1 for “Kat Herding Team!” :D
From: Whaley, Graham graham.whaley@intel.com Sent: Wednesday, August 8, 2018 7:39 AM To: yash jain ydjainopensource@gmail.com; kata-dev@lists.katacontainers.io Subject: Re: [kata-dev] Intel Gatekeepers for Kata
Sure, that should be no problem. I’ve added you into the table for that 8/27 slot. I will not that you are not currently a member of the kata-containers group on github – that is probably going to restrict your rights on the repos (like it may not let you merge etc.) – but, let’s see how it goes. You can still comment and nudge people on the Issues and PRs I believe, and when we get to the point where you need to start ack’ing and merging PRs, we will sort that out.
Thanks for stepping up!
Graham
From: yash jain [mailto:ydjainopensource@gmail.com] Sent: Wednesday, August 8, 2018 12:31 PM To: Whaley, Graham <graham.whaley@intel.commailto:graham.whaley@intel.com> Cc: bergwolf@hyper.shmailto:bergwolf@hyper.sh; kata-dev@lists.katacontainers.iomailto:kata-dev@lists.katacontainers.io; raravena80@gmail.commailto:raravena80@gmail.com Subject: Re: [kata-dev] Intel Gatekeepers for Kata
Hi,
This seems like a nice way to get familiar with the code base. I don't know if I will be able to deliver as much as the others but I would love to join you guys. Can I be assigned? Perhaps for the week starting 8/27 for APAC region?
On Wed, Aug 8, 2018 at 4:19 PM Whaley, Graham <graham.whaley@intel.commailto:graham.whaley@intel.com> wrote: Tao, Rico - thank you! for opting in
I have taken our current internal list of 'volunteers', modified it a bit and added the new volunteers in, and then embellished it with some useful other info. I've placed it up on the wiki. It can probably do with some shuffling of the rota - but we can work on that.
https://github.com/kata-containers/community/wiki/Review-Team-Rota
Can I ask all members in the Rota table to check they are available on those dates please.
JamesH and I threw around some funny names between us. Taking a bit of inspiration from JamesH and something EricE posted, I particularly like the idea of the 'Kat herding team', but I settled on the more sedate 'Kata review team'. Still, if enough folks want to change that name .... ;-)
We should probably make a top level wiki page with a link to that page (otherwise finding wiki pages on github can be a bit of an art), and probably make a PR to add a link into the community docs as well... once the page is settled then I'll try to remember to do that (and will go open an Issue for it right now..)
Graham
-----Original Message----- From: Tao Peng [mailto:bergwolf@hyper.shmailto:bergwolf@hyper.sh] Sent: Tuesday, August 7, 2018 2:24 AM To: Whaley, Graham <graham.whaley@intel.commailto:graham.whaley@intel.com> Cc: kata-dev@lists.katacontainers.iomailto:kata-dev@lists.katacontainers.io Subject: Re: [kata-dev] Intel Gatekeepers for Kata
On Mon, Aug 6, 2018 at 4:27 PM, Whaley, Graham <graham.whaley@intel.commailto:graham.whaley@intel.com> wrote:
Good morning. As Eric mentioned in last week's Arch call, the Kata team at Intel are trialing a
'round robin Gatekeeper schedule' for Kata PR review. That is, each week one of our team will prioritise reviewing and moving forwards the open PRs on the Kata repos. This is a process we used for some time with Clear Containers.
We are trying this out to see if we can try and reduce the pending PR list, in
particular some of the longer standing or more urgent PRs.
This is by no means an Intel-only initiative :-) If you want to be on the rota then
just let me know and I'll add you into the cycle. It would be great if we can try and get at least two nominated reviewers each week, ideally located in different time zones.
Note that to be a gatekeeper you don't have to understand the whole project,
or even have to be the most technical person. Being a gatekeeper is a great opportunity to both get to know the project in more depth and to hone your technical skills. Sometimes all it needs is for somebody to read the list of open PRs and nudge a few along that have been inactive and ask the appropriate domain experts if they could do a review. All volunteers welcome.
If you are new to the project and/or PR reviews, we have a PR review guide
document that is well worth reviewing: https://github.com/kata- containers/community/blob/master/PR-Review-Guide.md .
Today we are sat with 42 open items (you can coax that info out of github via
this link: https://github.com/search?o=asc&q=org%3Akata- containers+is%3Apr+is%3Aopen&s=created&type=Issues).
This week's gatekeeper is .... myself :-)
This is really a good idea. Thanks for bringing it up! Count me in! We really could use some dedicated forces to push forward long running issues/PRs.
And let's not abuse gatekeeper(TM) for it. "review team" and "PR Shepherd" both sound good to me.
Cheers, Tao
-- bergwolf@hyper.shmailto:bergwolf@hyper.sh
--------------------------------------------------------------------- Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ kata-dev mailing list kata-dev@lists.katacontainers.iomailto:kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
-- Thanks
Yash D Jain Github : @ydjainopensourcehttps://github.com/ydjainopensource Twitter : @Yash_D_Jainhttps://twitter.com/Yash_D_Jain LinkedIn : in/yash-d-jainhttps://www.linkedin.com/in/yash-d-jain/
--------------------------------------------------------------------- Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
+1 for “Kat Herding Team!” :D
I ... cough... may have inadvertently added some words to that effect on the rota page [1] :)
I've also:
- Tweaked the table to add active links to github pages [2]. - Changed the date format to ISO 8601 (for sanity). - Added a Notes column. - Added myself in an extra slot.
If anyone else wishes to add themselves into a free slot, feel free to do so! If you don't have perms, just ask the team [3] and we'll fix it for you.
Cheers,
James
[1] - https://github.com/kata-containers/community/wiki/Review-Team-Rota [2] - Note that I've added a set of links at the bottom of the page to simplify updating the table. If you want to add an exiting user to the table, just add "[user][user]". Or to add a new user, add "[newuser][newuser]" along with adding a "[newuser]: https://github.com/newuser" to the end of the rota page [1]. [3] - https://github.com/kata-containers/community#join-us
2018-08-08 19:05 GMT+01:00 Larrew, Jesse Jesse.Larrew@amd.com:
+1 for “Kat Herding Team!” :D
*From:* Whaley, Graham graham.whaley@intel.com *Sent:* Wednesday, August 8, 2018 7:39 AM *To:* yash jain ydjainopensource@gmail.com; kata-dev@lists.katacontainers.io
*Subject:* Re: [kata-dev] Intel Gatekeepers for Kata
Sure, that should be no problem. I’ve added you into the table for that 8/27 slot.
I will not that you are not currently a member of the kata-containers group on github – that is probably going to restrict your rights on the repos (like it may not let you merge etc.) – but, let’s see how it goes. You can still comment and nudge people on the Issues and PRs I believe, and when we get to the point where you need to start ack’ing and merging PRs, we will sort that out.
Thanks for stepping up!
Graham
*From:* yash jain [mailto:ydjainopensource@gmail.com ydjainopensource@gmail.com] *Sent:* Wednesday, August 8, 2018 12:31 PM *To:* Whaley, Graham graham.whaley@intel.com *Cc:* bergwolf@hyper.sh; kata-dev@lists.katacontainers.io; raravena80@gmail.com *Subject:* Re: [kata-dev] Intel Gatekeepers for Kata
Hi,
This seems like a nice way to get familiar with the code base. I don't know if I will be able to deliver as much as the others but I would love to join you guys. Can I be assigned? Perhaps for the week starting 8/27 for APAC region?
On Wed, Aug 8, 2018 at 4:19 PM Whaley, Graham graham.whaley@intel.com wrote:
Tao, Rico - thank you! for opting in
I have taken our current internal list of 'volunteers', modified it a bit and added the new volunteers in, and then embellished it with some useful other info. I've placed it up on the wiki. It can probably do with some shuffling of the rota - but we can work on that.
https://github.com/kata-containers/community/wiki/Review-Team-Rota
Can I ask all members in the Rota table to check they are available on those dates please.
JamesH and I threw around some funny names between us. Taking a bit of inspiration from JamesH and something EricE posted, I particularly like the idea of the 'Kat herding team', but I settled on the more sedate 'Kata review team'. Still, if enough folks want to change that name .... ;-)
We should probably make a top level wiki page with a link to that page (otherwise finding wiki pages on github can be a bit of an art), and probably make a PR to add a link into the community docs as well... once the page is settled then I'll try to remember to do that (and will go open an Issue for it right now..)
Graham
-----Original Message----- From: Tao Peng [mailto:bergwolf@hyper.sh] Sent: Tuesday, August 7, 2018 2:24 AM To: Whaley, Graham graham.whaley@intel.com Cc: kata-dev@lists.katacontainers.io Subject: Re: [kata-dev] Intel Gatekeepers for Kata
On Mon, Aug 6, 2018 at 4:27 PM, Whaley, Graham graham.whaley@intel.com wrote:
Good morning. As Eric mentioned in last week's Arch call, the Kata team at Intel are
trialing a
'round robin Gatekeeper schedule' for Kata PR review. That is, each week
one of
our team will prioritise reviewing and moving forwards the open PRs on
the Kata
repos. This is a process we used for some time with Clear Containers.
We are trying this out to see if we can try and reduce the pending PR
list, in
particular some of the longer standing or more urgent PRs.
This is by no means an Intel-only initiative :-) If you want to be on
the rota then
just let me know and I'll add you into the cycle. It would be great if
we can try
and get at least two nominated reviewers each week, ideally located in
different
time zones.
Note that to be a gatekeeper you don't have to understand the whole
project,
or even have to be the most technical person. Being a gatekeeper is a
great
opportunity to both get to know the project in more depth and to hone
your
technical skills. Sometimes all it needs is for somebody to read the
list of open
PRs and nudge a few along that have been inactive and ask the appropriate domain experts if they could do a review. All volunteers welcome.
If you are new to the project and/or PR reviews, we have a PR review
guide
document that is well worth reviewing: https://github.com/kata- containers/community/blob/master/PR-Review-Guide.md .
Today we are sat with 42 open items (you can coax that info out of
github via
this link: https://github.com/search?o=asc&q=org%3Akata- containers+is%3Apr+is%3Aopen&s=created&type=Issues).
This week's gatekeeper is .... myself :-)
This is really a good idea. Thanks for bringing it up! Count me in! We really could use some dedicated forces to push forward long running issues/PRs.
And let's not abuse gatekeeper(TM) for it. "review team" and "PR Shepherd" both sound good to me.
Cheers, Tao
-- bergwolf@hyper.sh
Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
--
Thanks
Yash D Jain
Github : @ydjainopensource https://github.com/ydjainopensource
Twitter : @Yash_D_Jain https://twitter.com/Yash_D_Jain
LinkedIn : in/yash-d-jain https://www.linkedin.com/in/yash-d-jain/
Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
participants (8)
-
Anne Bertucio
-
Fox, Kevin M
-
Hunt, James O
-
Larrew, Jesse
-
Ricardo Aravena
-
Tao Peng
-
Whaley, Graham
-
yash jain