I also think this is a great idea. I’d encourage folks to think of the process as transcending organization affiliation; we’re all members of the Kata Community now, so anyone is welcome to jump in! 

I think “review team” is a fine term, could even try to make a fun acronym out of “Reviewer of the Week” or something of the like (ROTW…ROW…ROW Master…still workshopping!). 

If a week is too long to be Rowing, we could explore people volunteering for one day a week? (You take every Monday…Graham takes Tuesdays…etc). There’d be some overlap because of time zone, but maybe a little lower commitment than being on for the full week.


Anne Bertucio
OpenStack Foundation
anne@openstack.org | irc: annabelleB





On Aug 6, 2018, at 9:49 AM, Whaley, Graham <graham.whaley@intel.com> wrote:

Ah, that is true - we are indeed not here to block anything - in fact, hopefully the opposite!
I'm open to suggestions. @anne, any ideas or precedents? 
Maybe just 'review team' will do?

(the fun link between having the Gatekeeper team and us trialling Zuul for our CI had not escaped me btw ;-) )

Oh, and I can't take all the credit here - a few of us started this on ClearContainers some time back, and EricE asked to resurrect it for Kata :-)

Graham

-----Original Message-----
From: Fox, Kevin M [mailto:Kevin.Fox@pnnl.gov]
Sent: Monday, August 6, 2018 5:41 PM
To: Whaley, Graham <graham.whaley@intel.com>; kata-
dev@lists.katacontainers.io
Subject: RE: Intel Gatekeepers for Kata

This is a great idea. Thanks for doing this. :)

I would recommend coming up with a different term then 'gatekeeper' though
to describe it. It could have an undesired connotation in the world of
opensource. Just a thought.

Thanks,
Kevin
________________________________________
From: Whaley, Graham [graham.whaley@intel.com]
Sent: Monday, August 06, 2018 1:27 AM
To: kata-dev@lists.katacontainers.io
Subject: [kata-dev] Intel Gatekeepers for Kata

Good morning.
As Eric mentioned in last week's Arch call, the Kata team at Intel are trialing a
'round robin Gatekeeper schedule' for Kata PR review. That is, each week one of
our team will prioritise reviewing and moving forwards the open PRs on the Kata
repos. This is a process we used for some time with Clear Containers.

We are trying this out to see if we can try and reduce the pending PR list, in
particular some of the longer standing or more urgent PRs.

This is by no means an Intel-only initiative :-) If you want to be on the rota then
just let me know and I'll add you into the cycle. It would be great if we can try
and get at least two nominated reviewers each week, ideally located in different
time zones.

Note that to be a gatekeeper you don't have to understand the whole project,
or even have to be the most technical person. Being a gatekeeper is a great
opportunity to both get to know the project in more depth and to hone your
technical skills. Sometimes all it needs is for somebody to read the list of open
PRs and nudge a few along that have been inactive and ask the appropriate
domain experts if they could do a review. All volunteers welcome.

If you are new to the project and/or PR reviews, we have a PR review guide
document that is well worth reviewing: https://github.com/kata-
containers/community/blob/master/PR-Review-Guide.md .

Today we are sat with 42 open items (you can coax that info out of github via
this link: https://github.com/search?o=asc&q=org%3Akata-
containers+is%3Apr+is%3Aopen&s=created&type=Issues).

This week's gatekeeper is .... myself :-)

Graham

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.


_______________________________________________
kata-dev mailing list
kata-dev@lists.katacontainers.io
http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.


_______________________________________________
kata-dev mailing list
kata-dev@lists.katacontainers.io
http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev