CI automatic trigger is now disabled in the tests repository
Hello,
Today I disabled the automatic build trigger from the CI but only on the tests repository. This is mainly to make some tests before implementing this approach across all repos. So now every new PR opened on the tests repo will need to be verified by an admin, who will be able to start the CI.
The commands that can be used for triggering the builds are: /test /retest retest this please - only for building failed jobs.
We will need to run the commands on every change that is made on the PR.
Limitations: 1. The /retest command will rebuild all Jobs (including the ones that passed). It is basically the same as /test. The command that is use to only rebuild failed jobs cannot be changed from the default one, which is: retest this please. So we have 2 options to rebuild failed jobs: 1. use the: "retest this please" command 2. go to Jenkins directly and rebuild the job from there. 2. The admin list can only be github users or organizations, so we won't be able to use the kata-containers teams that are registered in github. This means that all users registered in the kata-containers organization will be able to trigger the CI on every repository.
If someone wants to try this, there is a PR[1] where you can run the commands, or you can use any other of the PRs in the tests repository. If there are no comments or disagreements on this approach by tomorrow EOD, I will enable the rest of the repositories to use this approach.
Regards.
[1] https://github.com/kata-containers/tests/pull/755 Salvador Fuentes.
Thanks for the heads up :).
One comment: I wonder if the string "retest this please" can be replaced for " retest-this-please" or "retest-failed"
Thanks work on this Salvador :D .
- Carlos
-----Original Message----- From: Fuentes, Salvador [mailto:salvador.fuentes@intel.com] Sent: Tuesday, September 18, 2018 6:40 PM To: kata-dev@lists.katacontainers.io Subject: [kata-dev] CI automatic trigger is now disabled in the tests repository
Hello,
Today I disabled the automatic build trigger from the CI but only on the tests repository. This is mainly to make some tests before implementing this approach across all repos. So now every new PR opened on the tests repo will need to be verified by an admin, who will be able to start the CI.
The commands that can be used for triggering the builds are: /test /retest retest this please - only for building failed jobs.
We will need to run the commands on every change that is made on the PR.
Limitations: 1. The /retest command will rebuild all Jobs (including the ones that passed). It is basically the same as /test. The command that is use to only rebuild failed jobs cannot be changed from the default one, which is: retest this please. So we have 2 options to rebuild failed jobs: 1. use the: "retest this please" command 2. go to Jenkins directly and rebuild the job from there. 2. The admin list can only be github users or organizations, so we won't be able to use the kata-containers teams that are registered in github. This means that all users registered in the kata-containers organization will be able to trigger the CI on every repository.
If someone wants to try this, there is a PR[1] where you can run the commands, or you can use any other of the PRs in the tests repository. If there are no comments or disagreements on this approach by tomorrow EOD, I will enable the rest of the repositories to use this approach.
Regards.
[1] https://github.com/kata-containers/tests/pull/755 Salvador Fuentes.
_______________________________________________ kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
Hi,
On Tue, 2018-09-18 at 23:40 +0000, Fuentes, Salvador wrote:
Limitations:
- The admin list can only be github users or organizations, so we won't be able to use the kata-containers teams that are registered in github. This means that all users registered in the kata-containers organization will be able to trigger the CI on every repository.
Is it possible to whitelist github users not part of the kata- containers organization? Just asking for a friend ;)
Marco
From: Marco Vedovati [mailto:mvedovati@suse.com] Is it possible to whitelist github users not part of the kata- containers organization?
I believe we can. Well, there are two config boxes, one for a list of admin github names and the other (along with a tickbox) to add a github org and make them all admins. As long as those boxes are not mutually exclusive, then that should work....
Alternatively, you have been an active contributor quite a lot recently - you/we could always start the discussion of you applying to become an org member? You'd be the first one to go through the new process...
Just asking for a friend ;)
:-) - there was this man in the pub with a dog that.... heh
Marco
kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
--------------------------------------------------------------------- Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
In fact, adding to the org is much nicer as: - it keeps it much more formal - we can see who is in the org - special case-ing in the Jenkins config dialog has to be done on a per-job basis - and we have quite a lot of jobs. Salvador will not thank you if you has to go edit them all *again* :-)
Thus, I suggest applying to be a kata org member is the right route to go.
-----Original Message----- From: Whaley, Graham [mailto:graham.whaley@intel.com] Sent: Wednesday, September 19, 2018 9:50 AM To: Marco Vedovati mvedovati@suse.com; Fuentes, Salvador salvador.fuentes@intel.com; kata-dev@lists.katacontainers.io Subject: Re: [kata-dev] CI automatic trigger is now disabled in the tests repository
From: Marco Vedovati [mailto:mvedovati@suse.com] Is it possible to whitelist github users not part of the kata- containers organization?
I believe we can. Well, there are two config boxes, one for a list of admin github names and the other (along with a tickbox) to add a github org and make them all admins. As long as those boxes are not mutually exclusive, then that should work....
Alternatively, you have been an active contributor quite a lot recently - you/we could always start the discussion of you applying to become an org member? You'd be the first one to go through the new process...
Just asking for a friend ;)
:-) - there was this man in the pub with a dog that.... heh
Marco
kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
--------------------------------------------------------------------- Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
On Wed, 2018-09-19 at 08:58 +0000, Whaley, Graham wrote:
In fact, adding to the org is much nicer as:
- it keeps it much more formal - we can see who is in the org
- special case-ing in the Jenkins config dialog has to be done on a per-job basis - and we have quite a lot of jobs. Salvador will not thank you if you has to go edit them all *again* :-)
Thus, I suggest applying to be a kata org member is the right route to go.
That would be awesome :-)
Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
participants (4)
-
Fuentes, Salvador
-
Marco Vedovati
-
Venegas Munoz, Jose Carlos
-
Whaley, Graham