Hi everyone, The SoB/WIP checks are currently broken (since last Zuul restart last Friday), I'm waiting for the US to wake up to dive deeper into the cause and fix it... but I was wondering if we should not consider dropping the Zuul tenant, and just use some other GitHub integration instead. When PullApprove decided to change its ToS in 2019, we decided to reimplement the WIP and SoB checks using Zuul. The idea was to use it as a way for kata to experiment with Zuul and potentially move more of its testing in that direction. 18 months later, efforts to move more Kata testing toward Zuul seems to have been abandoned. Having a full Zuul tenant just to run things as basic as a WIP and SoB check is clearly overkill, and adds complexity / technical debt to the CI chain. Probot is open source and has DCO and WIP checks available. The main difference is that it only supports the word "WIP" (or "wip") being set in the PR title, and does not watch custom labels.... so you could no longer use a "do-not-merge" label for example. But otherwise we could migrate to it very quickly... Thoughts? Do you plan to use more Zuul jobs in the future, and maintaining a Kata tenant there makes sense ? Or should we just simplify the setup ? -- Thierry Carrez (ttx)
Hi Thierry, On Tue, Jul 21, 2020 at 12:14:46PM +0200, Thierry Carrez wrote:
Hi everyone,
The SoB/WIP checks are currently broken (since last Zuul restart last Friday), I'm waiting for the US to wake up to dive deeper into the cause and fix it... but I was wondering if we should not consider dropping the Zuul tenant, and just use some other GitHub integration instead.
When PullApprove decided to change its ToS in 2019, we decided to reimplement the WIP and SoB checks using Zuul. The idea was to use it as a way for kata to experiment with Zuul and potentially move more of its testing in that direction.
18 months later, efforts to move more Kata testing toward Zuul seems to have been abandoned. Having a full Zuul tenant just to run things as basic as a WIP and SoB check is clearly overkill, and adds complexity / technical debt to the CI chain.
Probot is open source and has DCO and WIP checks available. The main difference is that it only supports the word "WIP" (or "wip") being set in the PR title, and does not watch custom labels.... so you could no longer use a "do-not-merge" label for example. But otherwise we could migrate to it very quickly...
There are several github actions to check for custom labels and prevent them from being merged. For example: https://github.com/tim-actions/wip-check Combining probot for DCO only and for example the above gh action for custom labelled PR handling would allow us to not have to do it through Zuul anymore.
Thoughts? Do you plan to use more Zuul jobs in the future, and maintaining a Kata tenant there makes sense ? Or should we just simplify the setup ?
Simplify, as described above. Cheers, Samuel.
Thanks for investigating this Thierry. Le mar. 21 juil. 2020 à 11:50, Samuel Ortiz <sameo@linux.intel.com> a écrit :
Thoughts? Do you plan to use more Zuul jobs in the future, and
maintaining a
Kata tenant there makes sense ? Or should we just simplify the setup ?
Simplify, as described above.
+1 for simplifying using gh actions. Cheers, James --- https://katacontainers.io/ | https://github.com/kata-containers <https://github.com/clearcontainers> Open Source Technology Center Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ.
Samuel Ortiz wrote:
There are several github actions to check for custom labels and prevent them from being merged. For example: https://github.com/tim-actions/wip-check
Combining probot for DCO only and for example the above gh action for custom labelled PR handling would allow us to not have to do it through Zuul anymore.
There is a tim-actions thingy for DCO check too: https://github.com/tim-actions/dco In the spirit of not using a dozen different features, maybe we should avoid bringing in probot, and just configure actions. tim-actions have a bit unclear licensing, but seem to be ISC-licensed. -- Thierry Carrez (ttx)
My +1 for moving to github actions. We had a brief discussion on this last month with the goal to simplify processes and not use too many tools. Moving to actions should help with that. -Archana On 7/21/20, 5:23 AM, "Thierry Carrez" <thierry@openstack.org> wrote: Samuel Ortiz wrote: > There are several github actions to check for custom labels and prevent > them from being merged. For example: > https://github.com/tim-actions/wip-check > > Combining probot for DCO only and for example the above gh action for > custom labelled PR handling would allow us to not have to do it through > Zuul anymore. There is a tim-actions thingy for DCO check too: https://github.com/tim-actions/dco In the spirit of not using a dozen different features, maybe we should avoid bringing in probot, and just configure actions. tim-actions have a bit unclear licensing, but seem to be ISC-licensed. -- Thierry Carrez (ttx) _______________________________________________ kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
I have raised a PR in the kata-containers/kata-containers repository to use Github actions for performing the WIP and DCO checks. https://github.com/kata-containers/kata-containers/pull/438 We can extend the approach to other repositories once this is merged and move away from Zuul. -Archana ________________________________ From: Shinde, Archana M <archana.m.shinde@intel.com> Sent: Tuesday, July 21, 2020 11:11 AM To: Thierry Carrez <thierry@openstack.org>; kata-dev@lists.katacontainers.io <kata-dev@lists.katacontainers.io> Subject: Re: [kata-dev] WIP/SoB checks My +1 for moving to github actions. We had a brief discussion on this last month with the goal to simplify processes and not use too many tools. Moving to actions should help with that. -Archana On 7/21/20, 5:23 AM, "Thierry Carrez" <thierry@openstack.org> wrote: Samuel Ortiz wrote: > There are several github actions to check for custom labels and prevent > them from being merged. For example: > https://github.com/tim-actions/wip-check > > Combining probot for DCO only and for example the above gh action for > custom labelled PR handling would allow us to not have to do it through > Zuul anymore. There is a tim-actions thingy for DCO check too: https://github.com/tim-actions/dco In the spirit of not using a dozen different features, maybe we should avoid bringing in probot, and just configure actions. tim-actions have a bit unclear licensing, but seem to be ISC-licensed. -- Thierry Carrez (ttx) _______________________________________________ kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev _______________________________________________ kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
Shinde, Archana M wrote:
I have raised a PR in the kata-containers/kata-containers repository to use Github actions for performing the WIP and DCO checks. https://github.com/kata-containers/kata-containers/pull/438 We can extend the approach to other repositories once this is merged and move away from Zuul.
Quick status update on this: - The new GitHub-actions-powered WIP and SoB checks are in place in kata-containers:master and seem to be working well. - The Zuul-powered WIP/SoB checks are no longer "required" on any repo/branch, and should soon stop running on new PRs. - Archana posted PRs for adding the same actions to other repositories: https://github.com/pulls?q=is%3Aopen+is%3Apr+author%3Aamshinde+archived%3Afa... Next steps: - The PRs adding the GitHub-actions-powered checks will need to be backported to all branches. Most notably, it's missing from kata-containers:2.0-dev and blocking any change from landing there right now - Once in place the new GitHub-actions-powered WIP and SoB checks need to be set to "Required" for all repo/branches so that we don't accidentally merge PRs without DCO provided. -- Thierry Carrez (ttx)
An update: All the PRs for WIP and SoB checks have been backported to stable branches and merged. I have also set those checks to Required. Thierry, the Zuul checks should no longer be needed and can be disabled completely. -Archana On 7/23/20, 1:36 AM, "Thierry Carrez" <thierry@openstack.org> wrote: Shinde, Archana M wrote: > I have raised a PR in the kata-containers/kata-containers repository to > use Github actions for performing the WIP and DCO checks. > https://github.com/kata-containers/kata-containers/pull/438 > We can extend the approach to other repositories once this is merged and > move away from Zuul. Quick status update on this: - The new GitHub-actions-powered WIP and SoB checks are in place in kata-containers:master and seem to be working well. - The Zuul-powered WIP/SoB checks are no longer "required" on any repo/branch, and should soon stop running on new PRs. - Archana posted PRs for adding the same actions to other repositories: https://github.com/pulls?q=is%3Aopen+is%3Apr+author%3Aamshinde+archived%3Afa... Next steps: - The PRs adding the GitHub-actions-powered checks will need to be backported to all branches. Most notably, it's missing from kata-containers:2.0-dev and blocking any change from landing there right now - Once in place the new GitHub-actions-powered WIP and SoB checks need to be set to "Required" for all repo/branches so that we don't accidentally merge PRs without DCO provided. -- Thierry Carrez (ttx) _______________________________________________ kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
participants (4)
-
Hunt, James O
-
Samuel Ortiz
-
Shinde, Archana M
-
Thierry Carrez