-----Original Message----- From: Jeremy Stanley [mailto:fungi@yuggoth.org] Sent: Tuesday, January 8, 2019 4:42 PM To: kata-dev@lists.katacontainers.io Subject: Re: [kata-dev] PullApprove future
On 2019-01-08 16:27:29 +0000 (+0000), Whaley, Graham wrote: [...]
Whilst doing that I looked slightly deeper at probot, and indeed it does look like it has a number of features we would want to use. I’ve not looked into how it is configured/deployed – but presuming it needs a 24/7 machine, I’m sure we could either find one in our current CI system or discuss with the OSF infra folks deployment options.
At a slightly higher level, in my mind I wonder if this is a feature that more OSF infra projects may like/require beyond just being used by Kata – and maybe that will swing where it is deployed and managed. [...]
This is in fact a wildly popular feature of Zuul already for other OSF projects. You might even say it's Zuul's defining feature (the ability to interface with code review systems and merge changes triggered by specific events and defined sets of conditions). Probot sounds entirely redundant for the OpenDev infrastructure, and I can't imagine investing time in running more than one "pull request approver" engine, but I certainly don't speak for the rest of the OpenDev infra team.
Probot also looks like it's GitHub-only, and all other OSF projects besides Kata are using an open code review system (Gerrit). Keep in mind that what's happening today with PullApprove could happen tomorrow with GitHub. Free software needs free tools. </soapbox> -- Jeremy Stanley
Thanks Jeremy - do you have a quick link to the Zuul features and configuration, such as checking For signed off by's, keyword matching for merge blocking, gathering ack's before merge etc.? Right now for kata, all this would have to work seamlessly through github, as that is really the core goto place for the kata workflow. I can then add Zuul to the wiki page as an option. Thanks, Graham --------------------------------------------------------------------- Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.