Thanks very much Marco and welcome to the team! ;-) I've added your name to the rota. I'm in the UK so let's chat on irc/slack when you're about next week. Here's the full PR backlog (but don't let it put you off :)... - https://github.com/pulls?utf8=%E2%9C%93&q=is%3Aopen+is%3Apr+org%3Akata-containers Personally, I tend to "round robin" through the repos and crawl over the list of open PRs in each. If anyone else wants to join in, feel free to join us! Bottom line: the more PRs we can merge, the more bug fixes, optimisations and juicy new features we all get to benefit from :) Cheers, James 2018-08-31 15:56 GMT+01:00 Marco Vedovati <mvedovati@suse.com>:
Hi James, thanks for this great email.
I recently started getting familiar with Kata Containers, as my company (SUSE) wants to get more involved in this project and is also planning to integrate Kata in its Containers as a Service platform.
I'd like to help you out in some way, as learning by doing is effective and fun :-). So this PR reviewer role and the list of "easy" PR you proposed seem like a good way to start.
Cheers, Marco
On Fri, 2018-08-31 at 15:17 +0100, Hunt, James O wrote:
Hi All,
# TL;DR
If you'd like to get more exposure to Kata, please consider adding your name to the PR reviewer rota here:
- https://github.com/kata-containers/community/wiki/Review-Team-Rota (If you don't have permission to do this, please let us know [1]).
As shown, there are a few gaps which are just waiting for you to put your name in! :)
# Myth busting
- You don't need to be a repo maintainer
- You don't have to have done it before :)
- You *can* do it again :)
- There is no limit on the number of folk on the rota for a particular week
If someone already has their name down, you can add yours too! [2].
Ideally, we'd have lots of folk on the rota every week in all the different regions.
- You don't need to have read the PR review guide (although it should help)
It's just a guide and offers some thoughts on things to look out for.
- You don't have to spend the entire week doing it
We appreciate any time you can offer to help clear the PR backlogs.
And finally to the biggest myth of them all...
- You most certainly do *NOT* need to be an expert in golang or Kata
All contributions are appreciated. Further, we encourage everyone to ask as many "silly questions" on PRs as possible. Such "silly questions" are invaluable in helping "shake out" what on earth the author was thinking at the time they wrote the code (or doc) and can provide extremely valuable feedback to them as they may have made incorrect assumptions.
What we're striving for is of course correct code (and doc) but also code/doc that looks almost embarrassingly simple. If it looks too complex and/or the design/intent is not clear, the PR needs to be improved imho. We do this by gently guiding the author to a simpler, clearer result by asking questions and making suggestions (politely :)
# Reasons to help out
- Kudos of course! - You'll be helping the project increase velocity (getting all those new features and bug fixes landed faster!) - Learn more about how Kata works. - Learn about our processes. - Find areas that interest you.
There are still a lot of "low-hanging fruit" issues if you're looking for an area to start contributing to:
https://github.com/issues?utf8=%E2%9C%93&q=is%3Aopen+is% 3Aissue+org%3Akata-containers+label%3A%22good+first+issue%22
https://github.com/issues?utf8=%E2%9C%93&q=is%3Aopen+is% 3Aissue+org%3Akata-containers+label%3Abitesize
https://github.com/issues?utf8=%E2%9C%93&q=is%3Aopen+is% 3Aissue+org%3Akata-containers+label%3A%22help+wanted%22
- Learn how to debug Kata. - Learn how our CI works and how to debug issues. - ... and did I mention all the Kudos you'll get? :) - Kudos
# Further info
- https://github.com/kata-containers/community/blob/ master/CODE_OF_CONDUCT.md
(This one you do have to read and agree to :)
- https://github.com/kata-containers/community/blob/ master/PR-Review-Guide.md - https://github.com/kata-containers/community/blob/ master/Documentation-Review-Process.md - https://github.com/kata-containers/community/blob/master/CONTRIBUTING.md
Cheers,
James
[1] - https://github.com/kata-containers/community#join-us [2] - To add multiple names to a github table cell, use "<br/>" like this:
| users1 <br/> user2 <br/> user3 | --- https://katacontainers.io/o/ | https://github.com/kata-containers Open Source Technology Center Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ. _______________________________________________ kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
-- James --- https://katacontainers.io/ | https://github.com/kata-containers <https://github.com/clearcontainers> Open Source Technology Center Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ.