9 Nov
2018
9 Nov
'18
6:47 a.m.
On Fri, Nov 09, 2018 at 07:10:02PM +0800, Tao Peng wrote:
On Fri, Nov 9, 2018 at 6:46 PM Stefan Hajnoczi <stefanha@redhat.com> wrote:
It looks like the goroutine will be left running when kata-agent RemoveContainer() returns after a timeout. In addition, the sandbox lock is no longer held so any actions taken by the goroutine could cause problems.
Am I understanding the code correctly?
Yes, you are right! The main issue with the approach is that `ctr.removeContainer` doesn't honor timeout and we cannot force quit it in the middle.
Any suggestions?
If it's not possible to implement a timeout correctly then maybe the timeout parameter should be deprecated for now? Stefan