Request to fork cgroup-rs repository in Kata Containers organization
Hi architecture committee members, @liubin in our team has finished adding cgroups v2 support to the rust-agent. It is done by 1). moving from rustjail to cgroups-rs[1] for cgroups v1 support; 2). enhancing cgroups-rs with cgroups v2 support. While it is working, we face a dependency issue that the cgroups-rs project has been unmaintained for more than two year. So I'm writing to ask for your agreement to fork cgroups-rs repository in Kata Containers organization. That will allow us to add new features and bugfixes to it more easily and make sure the dependency is stable enough for Kata Containers' usage. Please share your opinions. Thanks! Cheers, Tao [1] https://github.com/levex/cgroups-rs -- Into something rich and strange.
Hi architecture committee members, @liubin in our team has finished adding cgroups v2 support to the rust-agent. It is done by 1). moving from rustjail to cgroups-rs[1] for cgroups v1 support; 2). enhancing cgroups-rs with cgroups v2 support. While it is working, we face a dependency issue that the cgroups-rs project has been unmaintained for more than two year. So I'm writing to ask for your agreement to fork cgroups-rs repository in Kata Containers organization. That will allow us to add new features and bugfixes to it more easily and make sure the dependency is stable enough for Kata Containers' usage. Please share your opinions. Thanks! Cheers, Tao [1]. https://github.com/levex/cgroups-rs -- Into something rich and strange.
On 4 Sep 2020, at 09:28, Peng Tao via kata-dev <kata-dev@lists.katacontainers.io> wrote:
Hi architecture committee members,
@liubin in our team has finished adding cgroups v2 support to the rust-agent. It is done by 1). moving from rustjail to cgroups-rs[1] for cgroups v1 support; 2). enhancing cgroups-rs with cgroups v2 support.
While it is working, we face a dependency issue that the cgroups-rs project has been unmaintained for more than two year. So I'm writing to ask for your agreement to fork cgroups-rs repository in Kata Containers organization. That will allow us to add new features and bugfixes to it more easily and make sure the dependency is stable enough for Kata Containers' usage.
Please share your opinions. Thanks!
59 commits, ~5000 lines of code, what I see looks sane. Probably need to add SPDX license identifiers for consistency with the rest of the code.
Cheers, Tao
[1]. https://github.com/levex/cgroups-rs
-- Into something rich and strange.
_______________________________________________ kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
[somehow I lost Xu, Eric and Justin in the CC list, adding them back...] On 2020/9/4 16:05, Christophe de Dinechin wrote:
On 4 Sep 2020, at 09:28, Peng Tao via kata-dev <kata-dev@lists.katacontainers.io> wrote:
Hi architecture committee members,
@liubin in our team has finished adding cgroups v2 support to the rust-agent. It is done by 1). moving from rustjail to cgroups-rs[1] for cgroups v1 support; 2). enhancing cgroups-rs with cgroups v2 support.
While it is working, we face a dependency issue that the cgroups-rs project has been unmaintained for more than two year. So I'm writing to ask for your agreement to fork cgroups-rs repository in Kata Containers organization. That will allow us to add new features and bugfixes to it more easily and make sure the dependency is stable enough for Kata Containers' usage.
Please share your opinions. Thanks!
59 commits, ~5000 lines of code, what I see looks sane.
Probably need to add SPDX license identifiers for consistency with the rest of the code.
Yeah, it makes sense. We can add them after forking the repository. Cheers, Tao
Cheers, Tao
[1]. https://github.com/levex/cgroups-rs
-- Into something rich and strange.
_______________________________________________ kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
-- Into something rich and strange.
I agree to fork it since the author had not response to Bin's previous PR and there has been no activities in the repo for about 2 years, though I think it would be more polite if we could try to mail the original author. Xu ------------------------------------------------------------------ From:彭涛(巴德) <bergwolf@hyper.sh> Send Time:2020年9月4日(星期五) 15:28 To:kata-dev <kata-dev@lists.katacontainers.io> Cc:Eric Ernst <eric.g.ernst@gmail.com>; 王旭(循环) <xu@hyper.sh>; "Ortiz, Samuel" <samuel.ortiz@intel.com>; Jia He <justin.he@arm.com>; caihaomin@huawei.com <caihaomin@huawei.com>; 刘斌(康德) <bin@hyper.sh> Subject:Request to fork cgroup-rs repository in Kata Containers organization Hi architecture committee members, @liubin in our team has finished adding cgroups v2 support to the rust-agent. It is done by 1). moving from rustjail to cgroups-rs[1] for cgroups v1 support; 2). enhancing cgroups-rs with cgroups v2 support. While it is working, we face a dependency issue that the cgroups-rs project has been unmaintained for more than two year. So I'm writing to ask for your agreement to fork cgroups-rs repository in Kata Containers organization. That will allow us to add new features and bugfixes to it more easily and make sure the dependency is stable enough for Kata Containers' usage. Please share your opinions. Thanks! Cheers, Tao [1]. https://github.com/levex/cgroups-rs -- Into something rich and strange.
On 2020/9/4 17:18, Xu Wang via kata-dev wrote:
I agree to fork it since the author had not response to Bin's previous PR and there has been no activities in the repo for about 2 years, though I think it would be more polite if we could try to mail the original author.
I did try to reach out by email to the original author but got rejected by the mail servers. Cheers, Tao
Xu
------------------------------------------------------------------ From:彭涛(巴德) <bergwolf@hyper.sh> Send Time:2020年9月4日(星期五) 15:28 To:kata-dev <kata-dev@lists.katacontainers.io> Cc:Eric Ernst <eric.g.ernst@gmail.com>; 王旭(循环) <xu@hyper.sh>; "Ortiz, Samuel" <samuel.ortiz@intel.com>; Jia He <justin.he@arm.com>; caihaomin@huawei.com <caihaomin@huawei.com>; 刘 斌(康德) <bin@hyper.sh> Subject:Request to fork cgroup-rs repository in Kata Containers organization
Hi architecture committee members,
@liubin in our team has finished adding cgroups v2 support to the rust-agent. It is done by 1). moving from rustjail to cgroups-rs[1] for cgroups v1 support; 2). enhancing cgroups-rs with cgroups v2 support.
While it is working, we face a dependency issue that the cgroups-rs project has been unmaintained for more than two year. So I'm writing to ask for your agreement to fork cgroups-rs repository in Kata Containers organization. That will allow us to add new features and bugfixes to it more easily and make sure the dependency is stable enough for Kata Containers' usage.
Please share your opinions. Thanks!
Cheers, Tao
[1]. https://github.com/levex/cgroups-rs
-- Into something rich and strange.
_______________________________________________ kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
It makes sense to me to fork. Can we open an issue on the repo to explain that we've forked the repo and that we're ready to push our work back there if it's active again at some point? Cheers, Samuel. On Fri, Sep 04, 2020 at 05:18:10PM +0800, Xu Wang wrote:
I agree to fork it since the author had not response to Bin's previous PR and there has been no activities in the repo for about 2 years, though I think it would be more polite if we could try to mail the original author.
Xu ------------------------------------------------------------------ From:彭涛(巴德) <bergwolf@hyper.sh> Send Time:2020年9月4日(星期五) 15:28 To:kata-dev <kata-dev@lists.katacontainers.io> Cc:Eric Ernst <eric.g.ernst@gmail.com>; 王旭(循环) <xu@hyper.sh>; "Ortiz, Samuel" <samuel.ortiz@intel.com>; Jia He <justin.he@arm.com>; caihaomin@huawei.com <caihaomin@huawei.com>; 刘斌(康德) <bin@hyper.sh> Subject:Request to fork cgroup-rs repository in Kata Containers organization
Hi architecture committee members,
@liubin in our team has finished adding cgroups v2 support to the rust-agent. It is done by 1). moving from rustjail to cgroups-rs[1] for cgroups v1 support; 2). enhancing cgroups-rs with cgroups v2 support.
While it is working, we face a dependency issue that the cgroups-rs project has been unmaintained for more than two year. So I'm writing to ask for your agreement to fork cgroups-rs repository in Kata Containers organization. That will allow us to add new features and bugfixes to it more easily and make sure the dependency is stable enough for Kata Containers' usage.
Please share your opinions. Thanks!
Cheers, Tao
[1]. https://github.com/levex/cgroups-rs
-- Into something rich and strange.
Intel Corporation SAS (French simplified joint stock company) Registered headquarters: "Les Montalets"- 2, rue de Paris, 92196 Meudon Cedex, France Registration Number: 302 456 199 R.C.S. NANTERRE Capital: 4,572,000 Euros This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
On 2020/9/4 19:10, Samuel Ortiz wrote:
It makes sense to me to fork. Can we open an issue on the repo to explain that we've forked the repo and that we're ready to push our work back there if it's active again at some point? Yes, definitely!
Cheers, Tao
Cheers, Samuel.
On Fri, Sep 04, 2020 at 05:18:10PM +0800, Xu Wang wrote:
I agree to fork it since the author had not response to Bin's previous PR and there has been no activities in the repo for about 2 years, though I think it would be more polite if we could try to mail the original author.
Xu ------------------------------------------------------------------ From:彭涛(巴德) <bergwolf@hyper.sh> Send Time:2020年9月4日(星期五) 15:28 To:kata-dev <kata-dev@lists.katacontainers.io> Cc:Eric Ernst <eric.g.ernst@gmail.com>; 王旭(循环) <xu@hyper.sh>; "Ortiz, Samuel" <samuel.ortiz@intel.com>; Jia He <justin.he@arm.com>; caihaomin@huawei.com <caihaomin@huawei.com>; 刘斌(康德) <bin@hyper.sh> Subject:Request to fork cgroup-rs repository in Kata Containers organization
Hi architecture committee members,
@liubin in our team has finished adding cgroups v2 support to the rust-agent. It is done by 1). moving from rustjail to cgroups-rs[1] for cgroups v1 support; 2). enhancing cgroups-rs with cgroups v2 support.
While it is working, we face a dependency issue that the cgroups-rs project has been unmaintained for more than two year. So I'm writing to ask for your agreement to fork cgroups-rs repository in Kata Containers organization. That will allow us to add new features and bugfixes to it more easily and make sure the dependency is stable enough for Kata Containers' usage.
Please share your opinions. Thanks!
Cheers, Tao
[1]. https://github.com/levex/cgroups-rs
-- Into something rich and strange.
Intel Corporation SAS (French simplified joint stock company) Registered headquarters: "Les Montalets"- 2, rue de Paris, 92196 Meudon Cedex, France Registration Number: 302 456 199 R.C.S. NANTERRE Capital: 4,572,000 Euros
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
On 4 Sep 2020, at 14:00, Peng Tao via kata-dev <kata-dev@lists.katacontainers.io> wrote:
On 2020/9/4 19:10, Samuel Ortiz wrote:
It makes sense to me to fork. Can we open an issue on the repo to explain that we've forked the repo and that we're ready to push our work back there if it's active again at some point? Yes, definitely!
We can simply open PRs initially with the changes, see what happens.
Cheers, Tao
Cheers, Samuel. On Fri, Sep 04, 2020 at 05:18:10PM +0800, Xu Wang wrote:
I agree to fork it since the author had not response to Bin's previous PR and there has been no activities in the repo for about 2 years, though I think it would be more polite if we could try to mail the original author.
Xu ------------------------------------------------------------------ From:彭涛(巴德) <bergwolf@hyper.sh> Send Time:2020年9月4日(星期五) 15:28 To:kata-dev <kata-dev@lists.katacontainers.io> Cc:Eric Ernst <eric.g.ernst@gmail.com>; 王旭(循环) <xu@hyper.sh>; "Ortiz, Samuel" <samuel.ortiz@intel.com>; Jia He <justin.he@arm.com>; caihaomin@huawei.com <caihaomin@huawei.com>; 刘斌(康德) <bin@hyper.sh> Subject:Request to fork cgroup-rs repository in Kata Containers organization
Hi architecture committee members,
@liubin in our team has finished adding cgroups v2 support to the rust-agent. It is done by 1). moving from rustjail to cgroups-rs[1] for cgroups v1 support; 2). enhancing cgroups-rs with cgroups v2 support.
While it is working, we face a dependency issue that the cgroups-rs project has been unmaintained for more than two year. So I'm writing to ask for your agreement to fork cgroups-rs repository in Kata Containers organization. That will allow us to add new features and bugfixes to it more easily and make sure the dependency is stable enough for Kata Containers' usage.
Please share your opinions. Thanks!
Cheers, Tao
[1]. https://github.com/levex/cgroups-rs
-- Into something rich and strange.
Intel Corporation SAS (French simplified joint stock company) Registered headquarters: "Les Montalets"- 2, rue de Paris, 92196 Meudon Cedex, France Registration Number: 302 456 199 R.C.S. NANTERRE Capital: 4,572,000 Euros This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
_______________________________________________ kata-dev mailing list kata-dev@lists.katacontainers.io <mailto:kata-dev@lists.katacontainers.io> http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev <http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev>
We did. Fupan once sent a PR there:
which has not gotten any reply for half a year... ------------------------------------------------------------------ From:Christophe de Dinechin <cdupontd@redhat.com> Send Time:2020年9月4日(星期五) 22:38 To:彭涛(巴德) <bergwolf@hyper.sh> Cc:Samuel Ortiz <samuel.ortiz@intel.com>; 王旭(循环) <xu@hyper.sh>; 刘斌(康德) <bin@hyper.sh>; caihaomin@huawei.com <caihaomin@huawei.com>; kata-dev <kata-dev@lists.katacontainers.io> Subject:Re: [kata-dev] Request to fork cgroup-rs repository in Kata Containers organization On 4 Sep 2020, at 14:00, Peng Tao via kata-dev <kata-dev@lists.katacontainers.io> wrote: On 2020/9/4 19:10, Samuel Ortiz wrote: It makes sense to me to fork. Can we open an issue on the repo to explain that we've forked the repo and that we're ready to push our work back there if it's active again at some point? Yes, definitely! We can simply open PRs initially with the changes, see what happens. Cheers, Tao Cheers, Samuel. On Fri, Sep 04, 2020 at 05:18:10PM +0800, Xu Wang wrote: I agree to fork it since the author had not response to Bin's previous PR and there has been no activities in the repo for about 2 years, though I think it would be more polite if we could try to mail the original author. Xu ------------------------------------------------------------------ From:彭涛(巴德) <bergwolf@hyper.sh> Send Time:2020年9月4日(星期五) 15:28 To:kata-dev <kata-dev@lists.katacontainers.io> Cc:Eric Ernst <eric.g.ernst@gmail.com>; 王旭(循环) <xu@hyper.sh>; "Ortiz, Samuel" <samuel.ortiz@intel.com>; Jia He <justin.he@arm.com>; caihaomin@huawei.com <caihaomin@huawei.com>; 刘斌(康德) <bin@hyper.sh> Subject:Request to fork cgroup-rs repository in Kata Containers organization Hi architecture committee members, @liubin in our team has finished adding cgroups v2 support to the rust-agent. It is done by 1). moving from rustjail to cgroups-rs[1] for cgroups v1 support; 2). enhancing cgroups-rs with cgroups v2 support. While it is working, we face a dependency issue that the cgroups-rs project has been unmaintained for more than two year. So I'm writing to ask for your agreement to fork cgroups-rs repository in Kata Containers organization. That will allow us to add new features and bugfixes to it more easily and make sure the dependency is stable enough for Kata Containers' usage. Please share your opinions. Thanks! Cheers, Tao [1]. https://github.com/levex/cgroups-rs -- Into something rich and strange. --------------------------------------------------------------------- Intel Corporation SAS (French simplified joint stock company) Registered headquarters: "Les Montalets"- 2, rue de Paris, 92196 Meudon Cedex, France Registration Number: 302 456 199 R.C.S. NANTERRE Capital: 4,572,000 Euros This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev _______________________________________________ kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
Hi all, Thank you for the timely support! As discussed, I have forked the cgroups-rs repository in Kata Containers organization [1] so that we can apply bugfixes and features more easily. In the meantime, I have created an issue [2] in the original cgroups-rs repository explaining why we did the fork and that we'll be more than happy to contribute all changes back once the original repository comes back to maintenance. Cheers, Tao [1] https://github.com/kata-containers/cgroups-rs [2] https://github.com/levex/cgroups-rs/issues/14 On 2020/9/5 09:10, Xu Wang via kata-dev wrote:
We did. Fupan once sent a PR there:
which has not gotten any reply for half a year...
------------------------------------------------------------------ From:Christophe de Dinechin <cdupontd@redhat.com> Send Time:2020年9月4日(星期五) 22:38 To:彭涛(巴德) <bergwolf@hyper.sh> Cc:Samuel Ortiz <samuel.ortiz@intel.com>; 王旭(循环) <xu@hyper.sh>; 刘斌(康德) <bin@hyper.sh>; caihaomin@huawei.com <caihaomin@huawei.com>; kata-dev <kata-dev@lists.katacontainers.io> Subject:Re: [kata-dev] Request to fork cgroup-rs repository in Kata Containers organization
On 4 Sep 2020, at 14:00, Peng Tao via kata-dev <kata-dev@lists.katacontainers.io <mailto:kata-dev@lists.katacontainers.io>> wrote:
On 2020/9/4 19:10, Samuel Ortiz wrote: It makes sense to me to fork. Can we open an issue on the repo to explain that we've forked the repo and that we're ready to push our work back there if it's active again at some point? Yes, definitely!
We can simply open PRs initially with the changes, see what happens.
Cheers, Tao
Cheers, Samuel. On Fri, Sep 04, 2020 at 05:18:10PM +0800, Xu Wang wrote: I agree to fork it since the author had not response to Bin's previous PR and there has been no activities in the repo for about 2 years, though I think it would be more polite if we could try to mail the original author.
Xu ------------------------------------------------------------------ From:彭涛(巴德) <bergwolf@hyper.sh <mailto:bergwolf@hyper.sh>> Send Time:2020年9月4日(星期五) 15:28 To:kata-dev <kata-dev@lists.katacontainers.io <mailto:kata-dev@lists.katacontainers.io>> Cc:Eric Ernst <eric.g.ernst@gmail.com <mailto:eric.g.ernst@gmail.com>>; 王旭(循环) <xu@hyper.sh <mailto:xu@hyper.sh>>; "Ortiz, Samuel" <samuel.ortiz@intel.com <mailto:samuel.ortiz@intel.com>>; Jia He <justin.he@arm.com <mailto:justin.he@arm.com>>; caihaomin@huawei.com <mailto:caihaomin@huawei.com> <caihaomin@huawei.com <mailto:caihaomin@huawei.com>>; 刘斌(康德) <bin@hyper.sh <mailto:bin@hyper.sh>> Subject:Request to fork cgroup-rs repository in Kata Containers organization
Hi architecture committee members,
@liubin in our team has finished adding cgroups v2 support to the rust-agent. It is done by 1). moving from rustjail to cgroups-rs[1] for cgroups v1 support; 2). enhancing cgroups-rs with cgroups v2 support.
While it is working, we face a dependency issue that the cgroups-rs project has been unmaintained for more than two year. So I'm writing to ask for your agreement to fork cgroups-rs repository in Kata Containers organization. That will allow us to add new features and bugfixes to it more easily and make sure the dependency is stable enough for Kata Containers' usage.
Please share your opinions. Thanks!
Cheers, Tao
[1]. https://github.com/levex/cgroups-rs
-- Into something rich and strange. --------------------------------------------------------------------- Intel Corporation SAS (French simplified joint stock company) Registered headquarters: "Les Montalets"- 2, rue de Paris, 92196 Meudon Cedex, France Registration Number: 302 456 199 R.C.S. NANTERRE Capital: 4,572,000 Euros This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ kata-dev mailing list kata-dev@lists.katacontainers.io <mailto:kata-dev@lists.katacontainers.io> http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
_______________________________________________ kata-dev mailing list kata-dev@lists.katacontainers.io <mailto:kata-dev@lists.katacontainers.io> http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
_______________________________________________ kata-dev mailing list kata-dev@lists.katacontainers.io http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev
-- Into something rich and strange.
participants (6)
-
Christophe de Dinechin
-
Peng Tao
-
Peng Tao
-
Peng Tao
-
Samuel Ortiz
-
Xu Wang