Hi all,
I am not sure that merging the test repository on the kata-containers repository will help to make easier the release process or if we will gain any benefit in doing it. I see a lot issues and a lot work that will need to be done if we
merge the test repository into kata-containers. First, we will need to change the CI installation scripts, the tests scripts, the Jenkins jobs configurations, the scripts that are running on the Github Actions, etc. Second, when we raise the PR to merge tests
in kata-containers, we will need to create a special CI to test this PR because if we only merge it without testing it well that will be a disaster. Third, do we have a strategy to merge PRs that are merged later on the test repository or what we are going
to do? Now about the release, I strongly believe that even if we merge the repos the release process the problem will be still there. The main issue why we spend a lot of time in doing releases is because the lack of backporting. In my experience, I have face
that people do not backport their PRs that are merge on main into the stable branches maybe because they forget, they do not know if a certain PR needs a backport or they just do not care about stable branches. If someone is doing a backport and a certain
CI is failing (which is non familiar or it is not the owner) an issue needs to be created and ask the owners to start to take a look in order to have help and fix the issue before the release process begins. I noticed that most of the time PRs are merged and
a certain CI is failing and no issues are created at all. Doing the merging of the repositories will require effort and time, even if a certain person only does the job this will require guidance and support from other members and I am not sure if this is
a priority for the project.
Regards,
Gabriela
From: Cameron Meadors <cmeadors@redhat.com>
Sent: Tuesday, August 17, 2021 2:00 PM
To: Fabiano Fidêncio <fabiano@fidencio.org>
Cc: kata-dev <kata-dev@lists.katacontainers.io>
Subject: Re: [kata-dev] About merging the tests repo into the kata-containers one
I only have one comment that I have already made and it got some traction so worth bringing up again. The comment is that there is value in separating e2e/integration tests that are not version specific from component/unit tests that are.
There should be much less churn in the non-version specific tests therefore reducing the overhead of having a separate repo. On the other hand, changes to version specific tests normally are made at the same time as their respective code changes. I am not
sure if we know which tests are version specific or not and if we are ready to make a forward looking decisions like this now, but I think keeping the test repo but only having non-versions specific tests there would solve the problems that have been presented.
I think it also might solve the problem that Gabriela's proposal would solve, although I don't fully understand that problem.
Anyway, just wanted to bring that up again. One single repo or two separate repos will both work. Just a matter of the tradeoffs.
On Mon, Aug 16, 2021 at 8:44 AM Fabiano Fidêncio <fabiano@fidencio.org> wrote:
During the last architecture committee meeting (Aug 10th, 2021) this
topic was brought up again and it's driven by simplifying the current
workflow.
Archana & Eric raised some concerns about the amount of churn / commit
pollution in the kata-containers repository.
This discussion is not new, we've had it on
https://github.com/kata-containers/kata-containers/issues/187 and we
even agreed in one of the meetings that merging the repo would be the
way to go, although it'd generate a lot of work that no-one at that
point would be willing to take.
Regardless of what was discussed, we didn't get the input of people
who are majoritarily working on that repo, being Gabriela & Salvador
the main ones, and I know they may have some concerns about the topic.
So, Gabriela, Salvador, would you mind sharing the concerns?
One last thing from my side, while I'm in favour of doing the move,
I'd like to ensure we take the decision based on the right
motivations. Merging the repos will *not* solve the problems we have
on maintaining the stable branches and, for that, please take a look
at Gabriela's proposal
https://github.com/kata-containers/kata-containers/issues/2429
Please, share your opinions, concerns, and ideas.
Best Regards,
--
Fabiano Fidêncio
_______________________________________________
kata-dev mailing list
kata-dev@lists.katacontainers.io
http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev