<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Helvetica;
panose-1:0 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.apple-converted-space
{mso-style-name:apple-converted-space;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Christophe, looks like the bug you mentioned is not public yet, alteast I am not able to access it.<o:p></o:p></p>
<p class="MsoNormal">Agree with disabling DAX, although as Snir mentioned would like to see any upstream bugs opened to track this.
<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">In addition, we are using a 5.6 kernel with Dax patches by default for virtiofs for both qemu-virtiofs and cloud-hypervisor. I propose we instead switch to the LTS 5.4 upstream kernel that has all the bits for virtiofs except Dax. If some
user wants to use dax, they can switch to the experimental 5.6 kernel instead. <o:p>
</o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">-Archana<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:12.0pt;color:black">From: </span></b><span style="font-size:12.0pt;color:black">Christophe de Dinechin <cdupontd@redhat.com><br>
<b>Date: </b>Friday, October 2, 2020 at 2:43 AM<br>
<b>To: </b>"Dr. David Alan Gilbert" <dgilbert@redhat.com><br>
<b>Cc: </b>kata-dev <kata-dev@lists.katacontainers.io><br>
<b>Subject: </b>Re: [kata-dev] Dax enablement in 2.0<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal"><br>
<br>
<o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">On 2 Oct 2020, at 11:24, Dr. David Alan Gilbert <<a href="mailto:dgilbert@redhat.com">dgilbert@redhat.com</a>> wrote:<o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal"><span style="font-size:13.5pt;font-family:Helvetica">* Fabiano Fidêncio (</span><a href="mailto:fidencio@redhat.com"><span style="font-size:13.5pt;font-family:Helvetica">fidencio@redhat.com</span></a><span style="font-size:13.5pt;font-family:Helvetica">)
wrote:<br style="caret-color: rgb(0, 0, 0);font-variant-caps: normal;text-align:start;-webkit-text-stroke-width: 0px;word-spacing:0px">
<br>
</span><o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span style="font-size:13.5pt;font-family:Helvetica">Snir,<br>
<br>
Firstly, let me reply to one specific bit of your email and also add a question.<br>
<br>
[...]<br>
<br>
<br>
<o:p></o:p></span></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span style="font-size:13.5pt;font-family:Helvetica">IIUC it's currently enabled by default (qemu), can it be disabled? if<br>
not, is it planned to be configurable?<o:p></o:p></span></p>
</blockquote>
<p class="MsoNormal"><span style="font-size:13.5pt;font-family:Helvetica"><br>
The current govmm codes only sets the "cache-size" when it's different<br>
from zero:<br>
<a href="https://github.com/intel/govmm/blob/master/qemu/qemu.go#L1256-L1258">https://github.com/intel/govmm/blob/master/qemu/qemu.go#L1256-L1258</a><br>
<br>
So, setting virtio_fs_cache_size here<br>
https://github.com/kata-containers/kata-containers/blob/2.0-dev/src/runtime/cli/config/configuration-qemu-virtiofs.toml.in#L113-L114<br>
disables DAX.<br>
<br>
A question I'd like to add to Snir's question is ...<br>
Wouldn't it be safer to have `virtio_fs_cache_size = 0` as a default<br>
value when using virtio-fs, at least till DAX gets solid?<o:p></o:p></span></p>
</blockquote>
<p class="MsoNormal"><span style="font-size:13.5pt;font-family:Helvetica"><br>
I think that should work; the current qemu vhost-user-fs.c code has:<br>
<br>
DEFINE_PROP_SIZE("cache-size", VHostUserFS, conf.cache_size, 0),<br>
<br>
so ommitting the property should give us 0 and cache disabled and<br>
ommitting the property also means you work with upstream qemu's.<br>
<br>
I do remember in older dev branches we had the default none-0<br>
but finally found the error of our ways.</span><o:p></o:p></p>
</div>
</blockquote>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p class="MsoNormal">Do you have any idea of the timeline for the DAX issues to be resolved?<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">2.0 is a long-lived branch, presumably, so we want to have something<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">in place that works when DAX is here.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">You may want to look at <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1876915#c30">
https://bugzilla.redhat.com/show_bug.cgi?id=1876915#c30</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><br>
<br>
<o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal"><span style="font-size:13.5pt;font-family:Helvetica"><br>
Dave<br>
<br>
<br style="caret-color: rgb(0, 0, 0);font-variant-caps: normal;text-align:start;-webkit-text-stroke-width: 0px;word-spacing:0px">
<br>
</span><o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span style="font-size:13.5pt;font-family:Helvetica">[...]<br>
<br>
Best Regards,<br>
--<span class="apple-converted-space"> </span><br>
Fabiano Fidêncio<br>
<br>
<br>
_______________________________________________<br>
kata-dev mailing list<br>
<a href="mailto:kata-dev@lists.katacontainers.io">kata-dev@lists.katacontainers.io</a><br>
<a href="http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev">http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev</a><o:p></o:p></span></p>
</blockquote>
<p class="MsoNormal"><span style="font-size:13.5pt;font-family:Helvetica">--<span class="apple-converted-space"> </span><br>
Dr. David Alan Gilbert /<span class="apple-converted-space"> </span></span><a href="mailto:dgilbert@redhat.com"><span style="font-size:13.5pt;font-family:Helvetica">dgilbert@redhat.com</span></a><span class="apple-converted-space"><span style="font-size:13.5pt;font-family:Helvetica"> </span></span><span style="font-size:13.5pt;font-family:Helvetica">/
Manchester, UK<br>
<br>
<br>
_______________________________________________<br>
kata-dev mailing list<br>
</span><a href="mailto:kata-dev@lists.katacontainers.io"><span style="font-size:13.5pt;font-family:Helvetica">kata-dev@lists.katacontainers.io</span></a><span style="font-size:13.5pt;font-family:Helvetica"><br>
</span><a href="http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev"><span style="font-size:13.5pt;font-family:Helvetica">http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev</span></a><o:p></o:p></p>
</div>
</blockquote>
</div>
<p class="MsoNormal"><br>
<br>
<o:p></o:p></p>
</div>
</body>
</html>