<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=gb2312">
</head>
<body dir="auto">
<div dir="ltr"></div>
<div dir="ltr">I tend to agree, James. </div>
<div dir="ltr"><br>
</div>
<div dir="ltr">Eric</div>
<div dir="ltr"><br>
On Feb 19, 2019, at 6:37 AM, Boeuf, Sebastien <<a href="mailto:sebastien.boeuf@intel.com">sebastien.boeuf@intel.com</a>> wrote:<br>
<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">
<div>Let's talk about this during the AC meeting :)</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Sebastien<br>
</div>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div id="divRpF400995" style="direction: ltr;"><font size="2" face="Tahoma" color="#000000"><b>From:</b> Hunt, James O [<a href="mailto:james.o.hunt@intel.com">james.o.hunt@intel.com</a>]<br>
<b>Sent:</b> Tuesday, February 19, 2019 12:36 AM<br>
<b>To:</b> Whaley, Graham<br>
<b>Cc:</b> kata-dev<br>
<b>Subject:</b> Re: [kata-dev] 答复: should github reset ack count on PR change?<br>
</font><br>
</div>
<div></div>
<div>
<div dir="ltr">
<div class="gmail_default" style="font-size:small">Having lived with this for a while now, I've decided I'm with Xu - I don't like the current behaviour: it's confusing ("wait, didn't I ack that PR yesterday?") and information is being lost (the ack history).</div>
<div class="gmail_default" style="font-size:small"><br>
</div>
<div class="gmail_default" style="font-size:small">I think there is value in others being able to see that a PR *was* ack'd, even if it's subsequently been updated. It's also clear to all which set of people could/should be pinged for a fresh ack as github
shows the timeline of events clearly on the PR.</div>
<div class="gmail_default" style="font-size:small"><br>
</div>
<div class="gmail_default" style="font-size:small">Cheers,</div>
<div class="gmail_default" style="font-size:small"><br>
</div>
<div class="gmail_default" style="font-size:small">James</div>
<div class="gmail_default" style="font-size:small"><br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">Le mer. 13 févr. 2019 à 10:45, Whaley, Graham <<a href="mailto:graham.whaley@intel.com" target="_blank" rel="noopener noreferrer">graham.whaley@intel.com</a>> a écrit :<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
<div lang="EN-GB">
<div class="gmail-m_2895540838532098342WordSection1">
<p class="MsoNormal"><font size="2" face="Calibri" color="#1f497d"><span style="font-size:11pt; font-family:Calibri,sans-serif; color:rgb(31,73,125)" lang="EN-US">Vote so far is 2 for reset, and 1 for leave-alone…<u></u><u></u></span></font></p>
<p class="MsoNormal"><font size="2" face="Calibri" color="#1f497d"><span style="font-size:11pt; font-family:Calibri,sans-serif; color:rgb(31,73,125)" lang="EN-US"><u></u> <u></u></span></font></p>
<p class="MsoNormal"><font size="2" face="Calibri" color="#1f497d"><span style="font-size:11pt; font-family:Calibri,sans-serif; color:rgb(31,73,125)" lang="EN-US">I will leave it on ‘reset on PR change’ right now, and we will see how it works out.<u></u><u></u></span></font></p>
<p class="MsoNormal"><font size="2" face="Calibri" color="#1f497d"><span style="font-size:11pt; font-family:Calibri,sans-serif; color:rgb(31,73,125)" lang="EN-US"><u></u> <u></u></span></font></p>
<p class="MsoNormal"><font size="2" face="Calibri" color="#1f497d"><span style="font-size:11pt; font-family:Calibri,sans-serif; color:rgb(31,73,125)" lang="EN-US">Thanks for the replies!<u></u><u></u></span></font></p>
<p class="MsoNormal"><a name="m_2895540838532098342__MailEndCompose"><font size="2" face="Calibri" color="#1f497d"><span style="font-size:11pt; font-family:Calibri,sans-serif; color:rgb(31,73,125)" lang="EN-US"><u></u> <u></u></span></font></a></p>
<div style="border-top:none; border-right:none; border-bottom:none; border-left:1.5pt solid blue; padding:0cm 0cm 0cm 4pt">
<div>
<div style="border-right:none; border-bottom:none; border-left:none; border-top:1pt solid rgb(225,225,225); padding:3pt 0cm 0cm">
<p class="MsoNormal"><a name="m_2895540838532098342______replyseparator"></a><b><font size="2" face="Calibri"><span style="font-size:11pt; font-family:Calibri,sans-serif; font-weight:bold" lang="EN-US">From:</span></font></b><font size="2" face="Calibri"><span style="font-size:11pt; font-family:Calibri,sans-serif" lang="EN-US">
Xu Wang [mailto:<a href="mailto:xu@hyper.sh" target="_blank" rel="noopener noreferrer">xu@hyper.sh</a>]
<br>
<b><span style="font-weight:bold">Sent:</span></b> Wednesday, February 13, 2019 6:47 AM<br>
<b><span style="font-weight:bold">To:</span></b> zhangwei (CR) <<a href="mailto:zhangwei555@huawei.com" target="_blank" rel="noopener noreferrer">zhangwei555@huawei.com</a>><br>
<b><span style="font-weight:bold">Cc:</span></b> Venegas Munoz, Jose Carlos <<a href="mailto:jose.carlos.venegas.munoz@intel.com" target="_blank" rel="noopener noreferrer">jose.carlos.venegas.munoz@intel.com</a>>; Whaley, Graham <<a href="mailto:graham.whaley@intel.com" target="_blank" rel="noopener noreferrer">graham.whaley@intel.com</a>>;
kata-dev <<a href="mailto:kata-dev@lists.katacontainers.io" target="_blank" rel="noopener noreferrer">kata-dev@lists.katacontainers.io</a>><br>
<b><span style="font-weight:bold">Subject:</span></b> Re: [kata-dev] </span></font><font size="2" face="MS Gothic"><span style="font-size:11pt; font-family:"MS Gothic"" lang="EN-US">答复</span></font><font size="2" face="Calibri"><span style="font-size:11pt; font-family:Calibri,sans-serif" lang="EN-US">:
should github reset ack count on PR change?<u></u><u></u></span></font></p>
</div>
</div>
<p class="MsoNormal"><font size="3" face="Times New Roman"><span style="font-size:12pt"><u></u> <u></u></span></font></p>
<div>
<p class="MsoNormal"><font size="3" face="Times New Roman"><span style="font-size:12pt">I like the pull-approve behavior (no reset) more...<u></u><u></u></span></font></p>
</div>
<p class="MsoNormal"><font size="3" face="Times New Roman"><span style="font-size:12pt"><u></u> <u></u></span></font></p>
<div>
<div>
<p class="MsoNormal"><font size="3" face="Times New Roman"><span style="font-size:12pt">On Wed, Feb 13, 2019 at 9:34 AM zhangwei (CR) <<a href="mailto:zhangwei555@huawei.com" target="_blank" rel="noopener noreferrer">zhangwei555@huawei.com</a>> wrote:<u></u><u></u></span></font></p>
</div>
<blockquote style="border-top:none; border-right:none; border-bottom:none; border-left:1pt solid rgb(204,204,204); padding:0cm 0cm 0cm 6pt; margin-left:4.8pt; margin-right:0cm">
<p class="MsoNormal"><font size="3" face="Times New Roman"><span style="font-size:12pt">I think we can try first with "reset" for security.<br>
We can still change it back if we find that it makes things too complicated. <br>
<br>
-----</span></font><font face="Microsoft JhengHei"><span style="font-family:"Microsoft JhengHei",sans-serif">邮件原件</span></font>-----<br>
<font face="Microsoft JhengHei"><span style="font-family:"Microsoft JhengHei",sans-serif">发件人</span></font>: Venegas Munoz, Jose Carlos [mailto:<a href="mailto:jose.carlos.venegas.munoz@intel.com" target="_blank" rel="noopener noreferrer">jose.carlos.venegas.munoz@intel.com</a>]
<br>
<font face="Microsoft JhengHei"><span style="font-family:"Microsoft JhengHei",sans-serif">发送时间</span></font>: 2019<font face="Calibri"><span style="font-family:Calibri,sans-serif">年</span></font>2<font face="Calibri"><span style="font-family:Calibri,sans-serif">月</span></font>13<font face="Calibri"><span style="font-family:Calibri,sans-serif">日</span></font>
4:36<br>
<font face="Calibri"><span style="font-family:Calibri,sans-serif">收件人</span></font>: Whaley, Graham <<a href="mailto:graham.whaley@intel.com" target="_blank" rel="noopener noreferrer">graham.whaley@intel.com</a>>; kata-dev <<a href="mailto:kata-dev@lists.katacontainers.io" target="_blank" rel="noopener noreferrer">kata-dev@lists.katacontainers.io</a>><br>
<font face="Calibri"><span style="font-family:Calibri,sans-serif">主</span></font><font face="Microsoft JhengHei"><span style="font-family:"Microsoft JhengHei",sans-serif">题</span></font>: Re: [kata-dev] should github reset ack count on PR change?<br>
<br>
I feel more secure that if the PR changes would need to re-ack.<br>
<br>
So +1 for reset ( this could slow our merge process), I hope not a lot. <br>
-<br>
Carlos<br>
<br>
<br>
-----Original Message-----<br>
From: Whaley, Graham [mailto:<a href="mailto:graham.whaley@intel.com" target="_blank" rel="noopener noreferrer">graham.whaley@intel.com</a>]
<br>
Sent: Tuesday, February 12, 2019 11:59 AM<br>
To: kata-dev <<a href="mailto:kata-dev@lists.katacontainers.io" target="_blank" rel="noopener noreferrer">kata-dev@lists.katacontainers.io</a>><br>
Subject: [kata-dev] should github reset ack count on PR change?<br>
<br>
Hi kata-devs,<br>
I'd like to cast a shout out for opinions on a bit of github PR workflow here....<br>
With the move from pullapprove to github to do the ack/nack counting, I had to make a decision on one of the github setup options.<br>
There is a tickbox that basically says 'if the PR changes, drop all existing acks and reset to 0'.<br>
We had a mixture of that being on/off across the repos. I set it to 'on' for them all, as notionally that seems like the right thing to do for a 'perfect workflow' (that is - if somebody changed the PR, how can you know your ack still applies etc. etc.).<br>
<br>
But, that is not how we had pullapprove working. Acks were sticky in pullapprove.<br>
And, tbh, most of the time the PRs are being updated to fix little things, and existing acks are mostly (99% of the time) OK to stick...<br>
<br>
What do we think - do we want acks sticky or not... I'm fairly OK either way, and will go setup/check github once we make a decision.<br>
<br>
Graham<br>
<br>
<br>
---------------------------------------------------------------------<br>
Intel Corporation (UK) Limited<br>
Registered No. 1134945 (England)<br>
Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47<br>
<br>
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.<br>
<br>
<br>
_______________________________________________<br>
kata-dev mailing list<br>
<a href="mailto:kata-dev@lists.katacontainers.io" target="_blank" rel="noopener noreferrer">kata-dev@lists.katacontainers.io</a><br>
<a href="http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev" target="_blank" rel="noopener noreferrer">http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev</a><br>
_______________________________________________<br>
kata-dev mailing list<br>
<a href="mailto:kata-dev@lists.katacontainers.io" target="_blank" rel="noopener noreferrer">kata-dev@lists.katacontainers.io</a><br>
<a href="http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev" target="_blank" rel="noopener noreferrer">http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev</a><br>
_______________________________________________<br>
kata-dev mailing list<br>
<a href="mailto:kata-dev@lists.katacontainers.io" target="_blank" rel="noopener noreferrer">kata-dev@lists.katacontainers.io</a><br>
<a href="http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev" target="_blank" rel="noopener noreferrer">http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev</a><u></u><u></u></p>
</blockquote>
</div>
<p class="MsoNormal"><font size="3" face="Times New Roman"><span style="font-size:12pt"><br clear="all">
<u></u><u></u></span></font></p>
<div>
<p class="MsoNormal"><font size="3" face="Times New Roman"><span style="font-size:12pt"><u></u> <u></u></span></font></p>
</div>
<p class="MsoNormal"><font size="3" face="Times New Roman"><span style="font-size:12pt">--
<u></u><u></u></span></font></p>
<div>
<div>
<div>
<p class="MsoNormal"><font size="2" face="Times New Roman"><span style="font-size:9.5pt">--<u></u><u></u></span></font></p>
</div>
<div>
<p class="MsoNormal"><font size="2" face="Times New Roman"><span style="font-size:9.5pt"><u></u> <u></u></span></font></p>
</div>
<div>
<p class="MsoNormal"><font size="2" face="Times New Roman"><span style="font-size:9.5pt">Xu Wang<u></u><u></u></span></font></p>
</div>
<div>
<p class="MsoNormal"><font size="2" face="Times New Roman"><span style="font-size:9.5pt">CTO & Cofounder, Hyper<u></u><u></u></span></font></p>
</div>
<div>
<p class="MsoNormal"><font size="2" face="Times New Roman"><span style="font-size:9.5pt">github/twitter/wechat: @gnawux<u></u><u></u></span></font></p>
</div>
<div>
<p class="MsoNormal"><font size="2" face="Times New Roman"><span style="font-size:9.5pt"><a href="http://hyper.sh/" target="_blank" rel="noopener noreferrer"><font color="#1155cc"><span style="color:rgb(17,85,204)">http://hyper.sh</span></font></a><u></u><u></u></span></font></p>
</div>
<div>
<p class="MsoNormal"><font size="2" face="Times New Roman"><span style="font-size:9.5pt"><u></u> <u></u></span></font></p>
</div>
<div>
<p class="MsoNormal"><font size="2" face="Times New Roman"><span style="font-size:9.5pt">Hyper_: Make VM run like container<u></u><u></u></span></font></p>
</div>
</div>
</div>
</div>
</div>
<p>---------------------------------------------------------------------<br>
Intel Corporation (UK) Limited<br>
Registered No. 1134945 (England)<br>
Registered Office: Pipers Way, Swindon SN3 1RJ<br>
VAT No: 860 2173 47</p>
<p>This e-mail and any attachments may contain confidential material for<br>
the sole use of the intended recipient(s). Any review or distribution<br>
by others is strictly prohibited. If you are not the intended<br>
recipient, please contact the sender and delete all copies.</p>
</div>
_______________________________________________<br>
kata-dev mailing list<br>
<a href="mailto:kata-dev@lists.katacontainers.io" target="_blank" rel="noopener noreferrer">kata-dev@lists.katacontainers.io</a><br>
<a href="http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev" rel="noreferrer" target="_blank">http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev</a><br>
</blockquote>
</div>
<br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr" class="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr"><font color="#888888"><span style="font-family:monospace,monospace"><span style="font-family:monospace,monospace">James<br>
---</span></span></font></div>
<div dir="ltr"><a href="https://katacontainers.io/" style="color:rgb(17,85,204); font-family:monospace,monospace" target="_blank" rel="noopener noreferrer">https://katacontainers.io/</a><span style="color:rgb(136,136,136); font-family:monospace,monospace"> |
<a href="https://github.com/clearcontainers" target="_blank" rel="noopener noreferrer">
https://github.com/kata-containers</a></span><font color="#888888"><span style="font-family:monospace,monospace"><span style="font-family:monospace,monospace"><br>
</span></span></font></div>
<div dir="ltr"><font color="#888888"><font face="monospace, monospace">Open Source Technology Center</font><br>
<font face="monospace, monospace">Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ.</font></font><br>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<blockquote type="cite">
<div dir="ltr"><span>_______________________________________________</span><br>
<span>kata-dev mailing list</span><br>
<span><a href="mailto:kata-dev@lists.katacontainers.io">kata-dev@lists.katacontainers.io</a></span><br>
<span><a href="http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev">http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev</a></span><br>
</div>
</blockquote>
</body>
</html>