<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"MS Gothic";
panose-1:2 11 6 9 7 2 5 8 2 4;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"Microsoft JhengHei";
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:"\@Microsoft JhengHei";
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:"\@MS Gothic";
panose-1:2 11 6 9 7 2 5 8 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-GB" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><font size="2" color="#1f497d" face="Calibri"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US">Vote so far is 2 for reset, and 1 for leave-alone…<o:p></o:p></span></font></p>
<p class="MsoNormal"><font size="2" color="#1f497d" face="Calibri"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></font></p>
<p class="MsoNormal"><font size="2" color="#1f497d" face="Calibri"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US">I will leave it on ‘reset on PR change’ right now, and we will see how it
works out.<o:p></o:p></span></font></p>
<p class="MsoNormal"><font size="2" color="#1f497d" face="Calibri"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></font></p>
<p class="MsoNormal"><font size="2" color="#1f497d" face="Calibri"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US">Thanks for the replies!<o:p></o:p></span></font></p>
<p class="MsoNormal"><a name="_MailEndCompose"><font size="2" color="#1f497d" face="Calibri"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></font></a></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><a name="_____replyseparator"></a><b><font size="2" face="Calibri"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;font-weight:bold">From:</span></font></b><font size="2" face="Calibri"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif">
Xu Wang [mailto:xu@hyper.sh] <br>
<b><span style="font-weight:bold">Sent:</span></b> Wednesday, February 13, 2019 6:47 AM<br>
<b><span style="font-weight:bold">To:</span></b> zhangwei (CR) <zhangwei555@huawei.com><br>
<b><span style="font-weight:bold">Cc:</span></b> Venegas Munoz, Jose Carlos <jose.carlos.venegas.munoz@intel.com>; Whaley, Graham <graham.whaley@intel.com>; kata-dev <kata-dev@lists.katacontainers.io><br>
<b><span style="font-weight:bold">Subject:</span></b> Re: [kata-dev] </span></font><font size="2" face="MS Gothic"><span lang="EN-US" style="font-size:11.0pt;font-family:"MS Gothic"">答复</span></font><font size="2" face="Calibri"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif">:
should github reset ack count on PR change?<o:p></o:p></span></font></p>
</div>
</div>
<p class="MsoNormal"><font size="3" face="Times New Roman"><span style="font-size:12.0pt"><o:p> </o:p></span></font></p>
<div>
<p class="MsoNormal"><font size="3" face="Times New Roman"><span style="font-size:12.0pt">I like the pull-approve behavior (no reset) more...<o:p></o:p></span></font></p>
</div>
<p class="MsoNormal"><font size="3" face="Times New Roman"><span style="font-size:12.0pt"><o:p> </o:p></span></font></p>
<div>
<div>
<p class="MsoNormal"><font size="3" face="Times New Roman"><span style="font-size:12.0pt">On Wed, Feb 13, 2019 at 9:34 AM zhangwei (CR) <<a href="mailto:zhangwei555@huawei.com">zhangwei555@huawei.com</a>> wrote:<o:p></o:p></span></font></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<p class="MsoNormal"><font size="3" face="Times New Roman"><span style="font-size:12.0pt">I think we can try first with "reset" for security.<br>
We can still change it back if we find that it makes things too complicated. <br>
<br>
-----</span></font><font face="Microsoft JhengHei"><span style="font-family:"Microsoft JhengHei",sans-serif">邮件原件</span></font>-----<br>
<font face="Microsoft JhengHei"><span style="font-family:"Microsoft JhengHei",sans-serif">发件人</span></font>: Venegas Munoz, Jose Carlos [mailto:<a href="mailto:jose.carlos.venegas.munoz@intel.com" target="_blank">jose.carlos.venegas.munoz@intel.com</a>]
<br>
<font face="Microsoft JhengHei"><span style="font-family:"Microsoft JhengHei",sans-serif">发送时间</span></font>: 2019<font face="Calibri"><span style="font-family:"Calibri",sans-serif">年</span></font>2<font face="Calibri"><span style="font-family:"Calibri",sans-serif">月</span></font>13<font face="Calibri"><span style="font-family:"Calibri",sans-serif">日</span></font>
4:36<br>
<font face="Calibri"><span style="font-family:"Calibri",sans-serif">收件人</span></font>: Whaley, Graham <<a href="mailto:graham.whaley@intel.com" target="_blank">graham.whaley@intel.com</a>>; kata-dev <<a href="mailto:kata-dev@lists.katacontainers.io" target="_blank">kata-dev@lists.katacontainers.io</a>><br>
<font face="Calibri"><span style="font-family:"Calibri",sans-serif">主</span></font><font face="Microsoft JhengHei"><span style="font-family:"Microsoft JhengHei",sans-serif">题</span></font>: Re: [kata-dev] should github reset ack count on PR change?<br>
<br>
I feel more secure that if the PR changes would need to re-ack.<br>
<br>
So +1 for reset ( this could slow our merge process), I hope not a lot. <br>
-<br>
Carlos<br>
<br>
<br>
-----Original Message-----<br>
From: Whaley, Graham [mailto:<a href="mailto:graham.whaley@intel.com" target="_blank">graham.whaley@intel.com</a>]
<br>
Sent: Tuesday, February 12, 2019 11:59 AM<br>
To: kata-dev <<a href="mailto:kata-dev@lists.katacontainers.io" target="_blank">kata-dev@lists.katacontainers.io</a>><br>
Subject: [kata-dev] should github reset ack count on PR change?<br>
<br>
Hi kata-devs,<br>
I'd like to cast a shout out for opinions on a bit of github PR workflow here....<br>
With the move from pullapprove to github to do the ack/nack counting, I had to make a decision on one of the github setup options.<br>
There is a tickbox that basically says 'if the PR changes, drop all existing acks and reset to 0'.<br>
We had a mixture of that being on/off across the repos. I set it to 'on' for them all, as notionally that seems like the right thing to do for a 'perfect workflow' (that is - if somebody changed the PR, how can you know your ack still applies etc. etc.).<br>
<br>
But, that is not how we had pullapprove working. Acks were sticky in pullapprove.<br>
And, tbh, most of the time the PRs are being updated to fix little things, and existing acks are mostly (99% of the time) OK to stick...<br>
<br>
What do we think - do we want acks sticky or not... I'm fairly OK either way, and will go setup/check github once we make a decision.<br>
<br>
Graham<br>
<br>
<br>
---------------------------------------------------------------------<br>
Intel Corporation (UK) Limited<br>
Registered No. 1134945 (England)<br>
Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47<br>
<br>
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.<br>
<br>
<br>
_______________________________________________<br>
kata-dev mailing list<br>
<a href="mailto:kata-dev@lists.katacontainers.io" target="_blank">kata-dev@lists.katacontainers.io</a><br>
<a href="http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev" target="_blank">http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev</a><br>
_______________________________________________<br>
kata-dev mailing list<br>
<a href="mailto:kata-dev@lists.katacontainers.io" target="_blank">kata-dev@lists.katacontainers.io</a><br>
<a href="http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev" target="_blank">http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev</a><br>
_______________________________________________<br>
kata-dev mailing list<br>
<a href="mailto:kata-dev@lists.katacontainers.io" target="_blank">kata-dev@lists.katacontainers.io</a><br>
<a href="http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev" target="_blank">http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev</a><o:p></o:p></p>
</blockquote>
</div>
<p class="MsoNormal"><font size="3" face="Times New Roman"><span style="font-size:12.0pt"><br clear="all">
<o:p></o:p></span></font></p>
<div>
<p class="MsoNormal"><font size="3" face="Times New Roman"><span style="font-size:12.0pt"><o:p> </o:p></span></font></p>
</div>
<p class="MsoNormal"><font size="3" face="Times New Roman"><span style="font-size:12.0pt">--
<o:p></o:p></span></font></p>
<div>
<div>
<div>
<p class="MsoNormal"><font size="2" face="Times New Roman"><span style="font-size:9.5pt">--<o:p></o:p></span></font></p>
</div>
<div>
<p class="MsoNormal"><font size="2" face="Times New Roman"><span style="font-size:9.5pt"><o:p> </o:p></span></font></p>
</div>
<div>
<p class="MsoNormal"><font size="2" face="Times New Roman"><span style="font-size:9.5pt">Xu Wang<o:p></o:p></span></font></p>
</div>
<div>
<p class="MsoNormal"><font size="2" face="Times New Roman"><span style="font-size:9.5pt">CTO & Cofounder, Hyper<o:p></o:p></span></font></p>
</div>
<div>
<p class="MsoNormal"><font size="2" face="Times New Roman"><span style="font-size:9.5pt">github/twitter/wechat: @gnawux<o:p></o:p></span></font></p>
</div>
<div>
<p class="MsoNormal"><font size="2" face="Times New Roman"><span style="font-size:9.5pt"><a href="http://hyper.sh/" target="_blank"><font color="#1155cc"><span style="color:#1155CC">http://hyper.sh</span></font></a><o:p></o:p></span></font></p>
</div>
<div>
<p class="MsoNormal"><font size="2" face="Times New Roman"><span style="font-size:9.5pt"><o:p> </o:p></span></font></p>
</div>
<div>
<p class="MsoNormal"><font size="2" face="Times New Roman"><span style="font-size:9.5pt">Hyper_: Make VM run like container<o:p></o:p></span></font></p>
</div>
</div>
</div>
</div>
</div>
<p>---------------------------------------------------------------------<br>
Intel Corporation (UK) Limited<br>
Registered No. 1134945 (England)<br>
Registered Office: Pipers Way, Swindon SN3 1RJ<br>
VAT No: 860 2173 47</p>
<p>This e-mail and any attachments may contain confidential material for<br>
the sole use of the intended recipient(s). Any review or distribution<br>
by others is strictly prohibited. If you are not the intended<br>
recipient, please contact the sender and delete all copies.</p></body>
</html>