<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" id="owaParaStyle">P {margin-top:0;margin-bottom:0;}</style>
</head>
<body fpstyle="1" ocsi="0">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">I also think that the first change that you described Sebastien, regarding the addition of PauseContainer could be considered backward compatible change requiring a change in the
minor number since we are just introducing new functionality here without breaking previous interfaces like CreateContainer etc.<br>
<br>
-Archana<br>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div id="divRpF207492" style="direction: ltr;"><font size="2" face="Tahoma" color="#000000"><b>From:</b> Jon Olson via kata-dev [kata-dev@lists.katacontainers.io]<br>
<b>Sent:</b> Thursday, June 21, 2018 12:05 PM<br>
<b>To:</b> Boeuf, Sebastien<br>
<b>Cc:</b> kata-dev@lists.katacontainers.io<br>
<b>Subject:</b> Re: [kata-dev] What to do about release versioning ?<br>
</font><br>
</div>
<div></div>
<div>
<div dir="ltr">
<div class="gmail_default" style="font-size:small">This came up in Vancouver, but I know not everyone had the opportunity to be there. Here were/are my thoughts drawing from my experience working on similar problems for GCE VMs: currently iiuc (until in-place-upgrade
and downgrade of releases is supported) the runtime and the guest image (including agent) are all part of the "release artifacts". I would argue that the protocol between the runtime and the agent is not (yet) part of the external contract for Kata. It probably
should be, but until that protocol is itself formally documented and versioned I would say you have only changed internal contracts between components that are part of the same atomic set of release artifacts.</div>
<div class="gmail_default" style="font-size:small"><br>
</div>
<div class="gmail_default" style="font-size:small">I do think it's valuable to make the agent protocol part of the external contract for Kata, but I think that requires the protocol itself be explicitly versioned[0].</div>
<div class="gmail_default" style="font-size:small"><br>
</div>
<div class="gmail_default" style="font-size:small">Jon<br>
</div>
<div class="gmail_default" style="font-size:small"><br>
</div>
<div class="gmail_default" style="font-size:small">
<div class="gmail_default" style="">[0]: I also still have an AI to put together a slide deck on gRPC API evolution best practices to minimize breaking changes generally. I should probably go do that.</div>
<div class="gmail_default" style=""><br>
</div>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Thu, Jun 21, 2018 at 11:54 AM Boeuf, Sebastien <<a href="mailto:sebastien.boeuf@intel.com" target="_blank">sebastien.boeuf@intel.com</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
<div>
<div style="direction:ltr; font-family:Tahoma; color:#000000; font-size:10pt">
<div>Hi folks,</div>
<div><br>
</div>
<div>This morning we wanted to release 1.0.1 but held on because of some discussions about the semver semantic not being followed with this 1.0.1 version.</div>
<div>The problem here, we have some "sort of" backward compatibility breakage between the runtime and the agent. And for any non compatible release, semver suggest that the new release should bump to the next X version (based on X.Y.Z notation).</div>
<div><br>
</div>
<div>But before we can answer this, we have to figure out what is that we consider a "breakage".</div>
<div><br>
</div>
<div>Let me try to explain the different possibility here, starting from an environment where you installed Kata 1.0.0 from packages:</div>
<div><br>
</div>
<div>First, let's say we introduced a new PauseContainer() command to our agent protocol, this command will have one commit on the agent repo, updating the gRPC protocol and implementing the new feature. This will be followed by a new patch on the runtime to
use this new feature, which means we'll have to revendor the new protocol and implement the runtime to rely on it.</div>
<div><br>
</div>
<div>Now, let's say we bump both runtime and agent repos including those patches to the version 1.0.1, here is the issue we will run into:</div>
<div>- The user with Kata 1.0.0 already installed on his system might update the kata-runtime package without updating the VM image containing the agent. And from his perspective, this is fine because he knows about semver semantics and thinks that a kata-runtime
1.0.1 might still work with the VM image container a kata-agent 1.0.0. Unfortunately, this won't work because the kata-runtime will try to call into the new command PauseContainer() that had been introduced, but the agent will have no idea about what this
is, and the gRPC will return an error saying this is not a supported/known command.</div>
<div><br>
</div>
<div>I have a second example, sorry this email is getting long but we have to talk about all cases here... Let's get back to 1.0.0 and say that some changes on both kata-runtime and kata-agent are modifying an existing command CreateContainer(). In this case,
this is a more logical breakage since moving one or the other component to the newest version without bumping the other (either kata-runtime 1.0.0 and kata-agent 1.0.1, or kata-runtime 1.0.1 and kata-agent 1.0.0), will end up in functional issues.</div>
<div><br>
</div>
<div>The second example is what I would call an obvious backward compatibility breakage, but the first one looks still valid to be taken into account.</div>
<div><br>
</div>
<div>So now, to summarize, we have to agree on what we call a non compatible version that will be translated into a bump to the next X version.</div>
<div>And I can see happening a lot of breakage in the future if we include both cases in what is considered as a "breakage", meaning we might end up on version 100.y.z pretty quickly.</div>
<div><br>
</div>
<div>Numbers are cheap, but here is the status and I/we need some feedback before we can push the pending release (as we don't want to introduce a wrong version number in the history).</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Sebastien<br>
</div>
</div>
</div>
_______________________________________________<br>
kata-dev mailing list<br>
<a href="mailto:kata-dev@lists.katacontainers.io" target="_blank">kata-dev@lists.katacontainers.io</a><br>
<a href="http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev" rel="noreferrer" target="_blank">http://lists.katacontainers.io/cgi-bin/mailman/listinfo/kata-dev</a><br>
</blockquote>
</div>
</div>
</div>
</div>
</body>
</html>