[kata-dev] kata-agent RemoveContainer timeout buggy?

Stefan Hajnoczi stefanha at redhat.com
Fri Nov 9 14:47:11 UTC 2018

On Fri, Nov 09, 2018 at 07:10:02PM +0800, Tao Peng wrote:
> On Fri, Nov 9, 2018 at 6:46 PM Stefan Hajnoczi <stefanha at redhat.com> wrote:
> >
> > It looks like the goroutine will be left running when kata-agent
> > RemoveContainer() returns after a timeout.  In addition, the sandbox
> > lock is no longer held so any actions taken by the goroutine could cause
> > problems.
> >
> > Am I understanding the code correctly?
> >
> Yes, you are right! The main issue with the approach is that
> `ctr.removeContainer` doesn't honor timeout and we cannot force quit
> it in the middle.
> Any suggestions?

If it's not possible to implement a timeout correctly then maybe the
timeout parameter should be deprecated for now?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: not available
URL: <http://lists.katacontainers.io/pipermail/kata-dev/attachments/20181109/e03d0bd4/attachment.sig>

More information about the kata-dev mailing list